Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

swagger response types and code #368

Merged
merged 1 commit into from
Oct 13, 2017
Merged

swagger response types and code #368

merged 1 commit into from
Oct 13, 2017

Conversation

SychevIgor
Copy link
Contributor

@SychevIgor
Copy link
Contributor Author

@CESARDELATORRE @RamonTC @eiximenis please, could you give me any feedback?

@SychevIgor SychevIgor changed the title swagge response types and code swagger response types and code Oct 12, 2017
@CESARDELATORRE
Copy link
Collaborator

OK, so you are basically adding the ProducesResponseType attribute, even when sometimes there's a single response type (like "200") but because most methods are returning an IActionResult instead of a direct DTO, right?
And sometimes, because you want to specify additional responses like "NotFound" or "Created", or your actions return IActionResult instead of a response DTO.
I think it looks good. I'm testing the PR and everything seems to work good.
@eiximenis Do you have anything else to add/comment?

@CESARDELATORRE
Copy link
Collaborator

Merging. Thanks SychevIgor! 👍

@CESARDELATORRE CESARDELATORRE merged commit ebcabe2 into dotnet-architecture:dev Oct 13, 2017
@SychevIgor SychevIgor deleted the swagger branch October 13, 2017 06:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants