Proj0039: Treat all warnings as errors is considered a bad practice

[Corniel]

I'm aware that this rule is opinionated, and I'm intending to release this with a severity info, instead of a warning. I'm also aware that this is by far the longest rule description, and is written more as a blog. Tips on how to improve that are (also) welcomed.

[Gemberkoekje]

I think it makes sense, although as you mention, some people will disagree.

[Corniel]

I think it makes sense, although as you mention, some people will disagree.

Are there arguments you disagree with? Sentences you would phrase differently? May be swap the order of the arguments?

[LauraXiulan]

I think I would end with developer unwillingness, first mention the technical reasons then the 'emotional' ones

[CptWesley]

Perhaps it's worth mentioning it is also possible to treat warnings as errors only during the CI pipeline, so that it doesn't block building locally

[Corniel]

Perhaps it's worth mentioning it is also possible to treat warnings as errors only during the CI pipeline, so that it doesn't block building locally

Sure, but that does not solve the main issue: it is rigid and contra-productive to have this enabled. Zero warnings should not be the main objective, having good code quality is. You could also say that this is of the category: If a measurement becomes a target, it looses is value as measurement.

So having the (only) enabled on the CI will not safe the day.

[Corniel]

I think I would end with developer unwillingness, first mention the technical reasons then the 'emotional' ones

So in which numerical order?

And why? Do you think that are the stronger arguments? Or do you think you should end with the strongest arguments? I think the first one is the strongest argument: you come op with some rigid setting to overcome a social issue, and that will not work.

[LauraXiulan]

Because it might put people off reading first that they are supposedly not willing to solve warnings, instead of first telling them why it might be a bad idea

[LauraXiulan]

The rest of the order is fine, maybe put the IDE last (because it is the last hurdle in the process)