-
Notifications
You must be signed in to change notification settings - Fork 25.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace NewtonSoftJson reference for Version 3.1 and newer #20791
Comments
MOved to Master list: Create a web API and MongoDB #16196 |
Rick, I'd love to contribute; however I'm unfamiliar with the process. If you're willing and able to point me to materials to understand the process or brief me, that would be great.
Abel Wenning
c: 714.900.9699
www.LinkedIn.com/in/AbelW<http://www.linkedin.com/in/abelw>
…________________________________
From: Rick Anderson <notifications@github.com>
Sent: Monday, November 30, 2020 2:42 PM
To: dotnet/AspNetCore.Docs <AspNetCore.Docs@noreply.github.com>
Cc: Abel Wenning <abelw@live.com>; Author <author@noreply.github.com>
Subject: Re: [dotnet/AspNetCore.Docs] Replace NewtonSoftJson reference for Version 3.1 and newer (#20791)
MOved to Master list: Create a web API and MongoDB #16196<#16196>
This doc needs alot of work. WOuld you be able to PR and fix a few bug?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#20791 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AJMHFUNEAUV7WMJEQKARBLDSSQNVJANCNFSM4UFTT43A>.
|
@the1abel do you need help with GitHub or just the process of updating a doc? I can help with updating the doc. |
I've only used GitHub for code, not for tutorial/documentation. If the tutorial/documentation is just HTML/CSHTML+CSS/Scss, that's easy—I'll just need to understand how you handle the various .NET Core versions of the tutorial (just separate HTML/CSHTML files or a more sophisticated CMS?).
I've not handled Pull Requests on GitHub, but I expect there are tutorials that I can read and test on my own repos to learn the ins and outs of that. Then, I presume I would need pointers on process/procedures specific to your way of doing things.
Abel Wenning
c: 714.900.9699
www.LinkedIn.com/in/AbelW<http://www.linkedin.com/in/abelw>
…________________________________
From: Rick Anderson <notifications@github.com>
Sent: Tuesday, December 1, 2020 3:26 PM
To: dotnet/AspNetCore.Docs <AspNetCore.Docs@noreply.github.com>
Cc: Abel Wenning <abelw@live.com>; Mention <mention@noreply.github.com>
Subject: Re: [dotnet/AspNetCore.Docs] Replace NewtonSoftJson reference for Version 3.1 and newer (#20791)
@the1abel<https://github.com/the1abel> do you need help with GitHub or just the process of updating a doc? I can help with updating the doc.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#20791 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AJMHFUP6KQ35GK6MS4EMPI3SSV3RPANCNFSM4UFTT43A>.
|
It's Markdown ( If you have time, I'll prepare the aspnetcore/tutorials/first-mongo-app.md by duplicating the content with monikers:
You would just update the 5.0 version. |
Oh, cool. MD is great. But, as you mention having time, I realize that I really shouldn't commit to anything additional on my plate right now, as much as I really would love to contribute.
I just started a new job, am still working on my BS in Software Engineering (yes, at age 43; I got a late start), and we just learned my wife is pregnant with our 5th child.
So, I should apologize for taking your time now, and I'll put it on my calendar to circle back with you in about a year.
Thanks for your time, and sorry for stealing some of it fruitlessly.
Abel Wenning
c: 714.900.9699
www.LinkedIn.com/in/AbelW<http://www.linkedin.com/in/abelw>
…________________________________
From: Rick Anderson <notifications@github.com>
Sent: Tuesday, December 1, 2020 5:15 PM
To: dotnet/AspNetCore.Docs <AspNetCore.Docs@noreply.github.com>
Cc: Abel Wenning <abelw@live.com>; Mention <mention@noreply.github.com>
Subject: Re: [dotnet/AspNetCore.Docs] Replace NewtonSoftJson reference for Version 3.1 and newer (#20791)
It's Markdown ( .md) files. Take a look at https://github.com/dotnet/AspNetCore.Docs/blob/master/CONTRIBUTING.md
If you have time, I'll prepare the aspnetcore/tutorials/first-mongo-app.md<https://github.com/dotnet/AspNetCore.Docs/blob/master/aspnetcore/tutorials/first-mongo-app.md> by duplicating the content with monikers:
::: moniker range=">= aspnetcore-5.0"
// copy of current version
::: moniker-end
::: moniker range="< aspnetcore-5.0"
// current version
::: moniker-end
You would just update the 5.0 version.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#20791 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AJMHFUJGFPBYAXG7YLKSNR3SSWIM7ANCNFSM4UFTT43A>.
|
Fixed in #24126, which now uses |
The following portion of this tutorial page should be updated for .NET Core Versions 3.1 and all newer versions.
In the "Configure JSON serialization options" section (#configure-json-serialization-options), the reference to NewtonSoftJson should be removed. This change is due to the addition of System.Text.Json in Version 3.1.
The following changes should be made (per https://docs.microsoft.com/en-us/dotnet/standard/serialization/system-text-json-how-to?pivots=dotnet-core-3-1#customize-individual-property-names):
[JsonProperty("Name")]
and instead insert[JsonPropertyName("Name")]
using Newtonsoft.Json;
and instead insertusing System.Text.Json.Serialization;
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.
The text was updated successfully, but these errors were encountered: