Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace NewtonSoftJson reference for Version 3.1 and newer #20791

Closed
the1abel opened this issue Nov 28, 2020 · 7 comments
Closed

Replace NewtonSoftJson reference for Version 3.1 and newer #20791

the1abel opened this issue Nov 28, 2020 · 7 comments
Labels
Source - Docs.ms Docs Customer feedback via GitHub Issue ⌚ Not Triaged

Comments

@the1abel
Copy link

The following portion of this tutorial page should be updated for .NET Core Versions 3.1 and all newer versions.
In the "Configure JSON serialization options" section (#configure-json-serialization-options), the reference to NewtonSoftJson should be removed. This change is due to the addition of System.Text.Json in Version 3.1.

The following changes should be made (per https://docs.microsoft.com/en-us/dotnet/standard/serialization/system-text-json-how-to?pivots=dotnet-core-3-1#customize-individual-property-names):

  1. Step HostingEngine.Start returns IDisposable. Usage patterns around IDisposable return values should be documented. #1 should be removed
  2. Step Configuring first article and author block #2 should be removed
  3. Step Add how to build in README.md #3 should remove [JsonProperty("Name")] and instead insert [JsonPropertyName("Name")]
  4. Step I am ready to translate #4 should remove using Newtonsoft.Json; and instead insert using System.Text.Json.Serialization;
  5. Step Migrating from ASP.NET MVC5 to MVC6, Part 1 #5 should remain the same

Document Details

Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

@Rick-Anderson
Copy link
Contributor

MOved to Master list: Create a web API and MongoDB #16196
This doc needs alot of work. WOuld you be able to PR and fix a few bug?

@the1abel
Copy link
Author

the1abel commented Dec 1, 2020 via email

@Rick-Anderson
Copy link
Contributor

@the1abel do you need help with GitHub or just the process of updating a doc? I can help with updating the doc.

@the1abel
Copy link
Author

the1abel commented Dec 2, 2020 via email

@Rick-Anderson
Copy link
Contributor

It's Markdown ( .md) files. Take a look at https://github.com/dotnet/AspNetCore.Docs/blob/master/CONTRIBUTING.md

If you have time, I'll prepare the aspnetcore/tutorials/first-mongo-app.md by duplicating the content with monikers:

::: moniker range=">= aspnetcore-5.0"
// copy of current version
::: moniker-end

::: moniker range="< aspnetcore-5.0"
// current version
::: moniker-end

You would just update the 5.0 version.

@the1abel
Copy link
Author

the1abel commented Dec 2, 2020 via email

@serpent5 serpent5 reopened this Nov 30, 2021
@serpent5
Copy link
Contributor

serpent5 commented Nov 30, 2021

Fixed in #24126, which now uses System.Text.json for the 6.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Source - Docs.ms Docs Customer feedback via GitHub Issue ⌚ Not Triaged
Projects
None yet
Development

No branches or pull requests

4 participants