Kestrel sample update to 5.0

[joancafom]

[EDIT by guardrex to add the metadata]

Help us make content visible

• Tell us what search terms you used and how you searched docs.
  kestrel, 5.0, sample, servers

• Tell us what docs you found that didn't address your concern.
  https://github.com/dotnet/AspNetCore.Docs/blob/master/aspnetcore/fundamentals/servers/kestrel.md

Describe the new topic

• Explain why this topic is needed.
  As you provide samples for 2.X and 3.X (take), it would be a good idea to support 5.X as well.

• Suggest a location in the Table of Contents.
  NA.

• Write an abstract. In one short paragraph, describe what this topic will cover.
  The current release of .NET version 5.0 does not seem to be compatible with any of the Kestrel Samples available in the repository (see ref), resulting in the following error:

  It was not possible to find any compatible framework version
  The framework 'Microsoft.AspNetCore.App' version '3.1.0' was not found.
    - The following frameworks were found:
         5.0.0 at [/opt/aspnet-core/bin/shared/Microsoft/AspNetCore.App]
  
  You can resolve the problem by installing the specified framework and/or SDK.

  I have seen you already addressed this issue in previous versions (for instance, in 3.1 Sample Updates #16170). Will you also be addressing this one?

• Create an outline for the new topic. We'll help review the outline and approve it before anyone writes a topic.

---

Document Details

⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

• ID: f22dcddb-0c25-be1a-9a02-9e71dce86bdb
• Version Independent ID: 3e0e12c2-e544-5655-e001-d2ec180b11a8
• Content: Kestrel web server implementation in ASP.NET Core
• Content Source: aspnetcore/fundamentals/servers/kestrel.md
• Product: aspnet-core
• Technology: aspnetcore-fundamentals
• GitHub Login: @Rick-Anderson
• Microsoft Alias: riande

[guardrex]

For a faster response, close this issue and re-open it using the This Page feedback button+form at the bottom of the English topic. It will add metadata to cross-link the topic and automatically ping the author.

[joancafom]

Thanks @guardrex but I can't happen to find neither the button nor the feedback section in the topic.

[guardrex]

@joancafom ...

It's here ...

https://docs.microsoft.com/en-us/aspnet/core/fundamentals/servers/kestrel?view=aspnetcore-5.0#feedback

... but I can just answer directly ...

This topic has been continuously updated and includes known (AFAIK) any Kestrel updates that apply to 5.0 (for example, #20261).

The problem is likely in the app. Create a new app using the 5.0 SDK and compare package references and framework in the project file of the new app to your app (and/or access the migration topics, for example: https://docs.microsoft.com/en-us/aspnet/core/migration/31-to-50?view=aspnetcore-5.0&tabs=visual-studio). Also, you might want to nuke the bin and obj folders and nuke the package caches with dotnet nuget locals --clear all. Then restore, build, and try running your app again.

[guardrex]

neither the button nor the feedback section in the topic

Can you provide a link to the topic (if not looking at the English-US version)? .... I'm curious if for some reason the Feedback section isn't showing up properly.

Note: If a Feedback issue is opened for the English-US topic, it shows up here for the docs team. If a Feedback issue is opened from a non-English-US topic, it opens for the localization folks (translation issues).

[joancafom]

Hi @guardrex

Thanks for your reply!

This topic has been continuously updated and includes known (AFAIK) any Kestrel updates that apply to 5.0 (for example, #20261).

Yes you are right about the topic being updated. However, I am more precisely talking about the Kestrel Sample app that is available in this same git repository:

AspNetCore.Docs/aspnetcore/fundamentals/servers/kestrel/samples/3.x/KestrelSample/KestrelSample.csproj

Lines 1 to 7 in d57a751

	<Project Sdk="Microsoft.NET.Sdk.Web">
	<PropertyGroup>
	<TargetFramework>netcoreapp3.1</TargetFramework>
	</PropertyGroup>
	</Project>

As per your recommended migration guide, this file should be updated to:

<Project Sdk="Microsoft.NET.Sdk.Web">

  <PropertyGroup>
-    <TargetFramework>netcoreapp3.1</TargetFramework>
+    <TargetFramework>net5.0</TargetFramework>
  </PropertyGroup>

</Project>

The problem is likely in the app.

We are using the aforementioned KestreSample app, but only entries for 2.X and 3.X are available:
https://github.com/dotnet/AspNetCore.Docs/tree/master/aspnetcore/fundamentals/servers/kestrel/samples

[joancafom]

Can you provide a link to the topic (if not looking at the English-US version)? .... I'm curious if for some reason the Feedback section isn't showing up properly.

Note: If a Feedback issue is opened for the English-US topic, it shows up here for the docs team. If a Feedback issue is opened from a non-English-US topic, it opens for the localization folks (translation issues).

Reloading the page seems to solve the issue, now it appears 🙂

[guardrex]

Oh, yes ... I forgot about that. I used to work on this topic quite a bit, but others have taken it over since then because I work on Blazor topics now.

I'll add the metadata for the topic manually to this issue.

To update the sample, we usually create a new 5.x sample app. That sort of work needs to be done across the repo. I have a feeling that many sample apps are in the same boat for 5.0, given that 5.0 just came out a couple of weeks ago. I occasionally ... roughly annually ... update the sample tracking issue, and I probably need to do that again ...

#5495

It's nice because it shows the exact state of samples, then the high visibility, most-used sample apps can be worked into the latest version. @Rick-Anderson will let us know if we should continue with that approach or if that issue should be closed in favor of a more ad-hoc process. There are even more samples on the repo now than there were the last time I updated that issue, so it might be intractable to continue maintaining a tracking issue. Rick, I can update that issue near my departure for 🏖️ ... which is a bit of a dud given that it's a pandemic stay-cation ... I ain't go'in nowhere! 😢 ... but yeah ... it takes a few hours to update it, and I'd have time to do that in a couple of weeks right before I ✈️ to ... uh ... nowhere. 😢

[Rick-Anderson]

As you provide samples for 2.X and 3.X (take), it would be a good idea to support 5.X as well.

Not enough changes from 3.1 to 5.x to warrant a new sample.
Thanks for contacting us.
We don’t have the resources to invest in this area, so we are closing the issue. Should your request generate enough 👍 responses, we’ll reconsider. We'll also reconsider this issue in the next doc update.