Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3.1 Sample Updates #16170

Merged
merged 1 commit into from
Dec 12, 2019
Merged

3.1 Sample Updates #16170

merged 1 commit into from
Dec 12, 2019

Conversation

guardrex
Copy link
Collaborator

Addresses #5495

  • The low-hanging fruit ones that can be updated without too much concern that they'll 💥 on us without testing.
  • A handful of others will be put up on later PR(s) because they're complicated enough that they warrant a test run when updating to 3.1.

Rick-Anderson
Rick-Anderson approved these changes Dec 12, 2019
View reviewed changes
Copy link
Contributor

@Rick-Anderson Rick-Anderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'm going to guarantee this won't cause problems :)

@guardrex
Copy link
Collaborator Author

guardrex commented Dec 12, 2019 •
edited
Loading

From you to the 🙏 server gods 👂 🙏.

@guardrex guardrex merged commit 4a16dc2 into master Dec 12, 2019
@guardrex guardrex deleted the guardrex/sample-update-31 branch December 12, 2019 23:31
Rick-Anderson added a commit that referenced this pull request Dec 14, 2019
@Rick-Anderson
Master to live Dec 14 (#16201)
13674f9 
* 3.1 Sample Updates (#16170)

* Update model.md (#16180)

* Update spa-services.md (#16182)

* Update azure-ad-b2c-webapi.md (#16185)

* Update index.md (#16184)

* C150960: Changing three dashes by three underscores to avoid issues on localized pages (#16183)

Localization team has reported source content issue that causes localized version to have broken/different format compared to en-us version.
Description: Three dashes in a row act similar to backticks (\`\`\`) and leave content un-localizable

* Update identity-2x.md (#16179)

* Update error-handling.md (#16193)

* Update error-handling.md

* Update error-handling.md

* Update error-handling.md

* Update validation.md

* remove blazor samples from toc.yml (#16194)

* Update index.md (#16173)

* Update index.md

* Apply suggestions from code review

Co-Authored-By: Luke Latham <1622880+guardrex@users.noreply.github.com>

* Update aspnetcore/fundamentals/logging/index.md

Co-Authored-By: Luke Latham <1622880+guardrex@users.noreply.github.com>

* Update aspnetcore/fundamentals/logging/index.md

Co-Authored-By: Luke Latham <1622880+guardrex@users.noreply.github.com>

* Add note on RegularExpression attribute validation (#15984)

* Add note on RegularExpression attribute validation

This note will help inform developers of the limitations.

* Update validation.md

* Update validation.md

* Update validation.md

* Update validation.md

* Update validation.md

* Update validation.md

* Update validation.md
@joancafom joancafom mentioned this pull request Dec 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rick-Anderson Rick-Anderson Rick-Anderson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guardrex @Rick-Anderson