-
Notifications
You must be signed in to change notification settings - Fork 25.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transient Scope for Custom AuthorizationMessageHandler class #26528
Comments
cc: @javiercn ... This one requires your help 🚓🚑🚒. Thanks for the issue, @Zhiyuan-Amos. It was transient prior to the release of 3.2.1. We changed it at the same time that Blazor scoped service registrations ... which came about via docs issue ... [3.1.6] Incorrect HTTPClient registration ... which was based on the PU issue ... [Blazor] HttpClient is registered incorrectly ... with @javiercn's PR at ... [Blazor] Register HttpClient as a scoped instance
The docs PR was perhaps overzealous because I noticed that So, we'll need a ruling on this one, and then ...
|
This comment was marked as spam.
This comment was marked as spam.
UPDATE (8/11): Very sorry for the delay! There's a delay due to the work for the upcoming .NET 7 release. We'll get to this ASAP, but I don't have an ETA. |
New information on this that resolves it ... Leave this open, @Zhiyuan-Amos, as I plan to clarify it in the docs based on Javier's remarks there ...
|
does this delay really matter?
Pada tanggal Kam, 11 Agu 2022 21:54, ***@***.***>
menulis:
… *UPDATE (8/11)*: *Very sorry for the delay!* There's a delay due to the
work going on for the upcoming .NET 7 release. We'll get to this *ASAP*,
but I don't have an ETA.
—
Reply to this email directly, view it on GitHub
<#26528 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A2CJRSNRLWIS6G4ESW2VTOLVYUH3DANCNFSM54NJM7PQ>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Got it.
Pada tanggal Jum, 12 Agu 2022 17:21, ***@***.***>
menulis:
… New information on this that resolves it ...
dotnet/aspnetcore#43234
<dotnet/aspnetcore#43234>
Leave this open, @Zhiyuan-Amos <https://github.com/Zhiyuan-Amos>, as I
plan to clarify it in the docs based on Javier's remarks there.
—
Reply to this email directly, view it on GitHub
<#26528 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A2CJRSMPIFWSAZODIGBY7QLVYYQTDANCNFSM54NJM7PQ>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
does this delay really matter?
Pada tanggal Kam, 11 Agu 2022 21:54, Luke Latham ***@***.***>
menulis:
… *UPDATE (8/11)*: *Very sorry for the delay!* There's a delay due to the
work going on for the upcoming .NET 7 release. We'll get to this *ASAP*,
but I don't have an ETA.
—
Reply to this email directly, view it on GitHub
<#26528 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A2CJRSNRLWIS6G4ESW2VTOLVYUH3DANCNFSM54NJM7PQ>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
This was resolved by #26755. |
Hello! The document contains the following code snippet:
where
CustomAuthorizationMessageHandler
is registered as aScoped
service (// 1
). However, the documentation forAddHttpMessageHandler<THandler>(IHttpClientBuilder)
(// 2
) specifies thatCustomAuthorizationMessageHandler
must be registered as aTransient
service:There seems to be a difference in the lifetime (
scoped
vstransient
) across the above documentations. Might this be an error in the documentation, or am I understanding the docs incorrectly?Thank you!
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.
The text was updated successfully, but these errors were encountered: