Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Describe new client code generation Swagger features #8462

Closed
Rick-Anderson opened this issue Sep 8, 2018 — with docs.microsoft.com · 10 comments
Closed

Describe new client code generation Swagger features #8462

Rick-Anderson opened this issue Sep 8, 2018 — with docs.microsoft.com · 10 comments
Labels
area-mvc doc-enhancement Pri1 Source - Docs.ms Docs Customer feedback via GitHub Issue

Comments

Copy link
Contributor

Rick-Anderson commented Sep 8, 2018

Copy from #8460 by @dougbu - we like to open doc issues from the doc page so they show up in the Feedback section of the doc.

General

https://docs.microsoft.com/en-ca/aspnet/core/tutorials/web-api-help-pages-using-swagger?view=aspnetcore-2.1 covers the current state of client code generation in ASP.NET Core web sites. However, we're working to give customers simple ways to annotate their project files for automated code generation during every build (as source API descriptions change) and that should also be documented.

Note tooling for the new experience isn't going to happen immediately. The initial documentation should focus on manual edits to .csproj files.

Issues with Existing Topics

Does not cover work described in dotnet/aspnetcore#4896 and its sub-issues.

CC

@glennc


Document details

Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

Copy link
Member

dougbu commented Sep 8, 2018

Should have mentioned in my original comment: The new feature will give end users many customization options. The documentation should cover MSBuild properties and item metadata they can set to affect code generation.

End users may also customize web sites that can generate API descriptions (as described in the next-level "Getting started with" pages). In this case, the optional settings control defaults for how a tool run from a consuming project will retrieve API descriptions.

@glennc
Copy link
Contributor

glennc commented Nov 29, 2018

You can now get an example of this working e2e using NSwag, but it isn't going to be completely RTM for 2.2. I think the best we can do here is start working on this doc first thing after the 2.2 ships as we will RTM it while we work on 3.0.

@aidapsibr
Copy link

I'd love to see more docs around NSWAG for dotnetcore CI scenarios (msbuild preferably, but CLI would be ok).

Additionally, the problem details support such as what happens out of the box if anything, how should I set it up, how does OpenAPI and ApiExplorer learn from that, does NSWAG support this model, do I use the Extensions dictionary or inherit and add properties?

IMO these two experiences, along with docker work being done really empower micro-service design.

@RicoSuter
Copy link
Contributor

RicoSuter commented Jan 11, 2019

I'd love to see more docs around NSWAG for dotnetcore CI scenarios (msbuild preferably, but CLI would be ok).

I think we shouldn't add too much specific NSwag documentation here - just add links to the NSwag project wiki. This way it is much easier to keep the docs up-to-date and consistent...

@Rick-Anderson Rick-Anderson changed the title Describe new client code generation features (planned for 2.2 Preview 3) Describe new client code generation Swagger features Jan 11, 2019
@tdykstra tdykstra assigned tdykstra and unassigned scottaddie Feb 21, 2019
@tdykstra tdykstra modified the milestones: Backlog, Sprint Mar 11, 2019
@tdykstra tdykstra removed their assignment Mar 22, 2019
@dougbu dougbu added the PU label Apr 6, 2019
@dougbu dougbu self-assigned this Apr 6, 2019
@dougbu dougbu modified the milestones: Sprint, 3.0.0-preview6 Apr 6, 2019
@ryanbrandenburg ryanbrandenburg self-assigned this May 21, 2019
@dougbu
Copy link
Member

dougbu commented Jun 23, 2019

7c22abe gets us closer but need partner releases using the latest features to complete this work.

@cremor
Copy link

cremor commented Oct 17, 2019

Is there a way to get this issue to show up in the feedback section of Develop ASP.NET Core apps using OpenAPI tools?

I was already in the process of writing an issue that this feature should be described in way more detail when I remembered this issue here. It would be good if readers of that page didn't get the idea that that's all that can be said about the feature.

@Rick-Anderson
Copy link
Contributor Author

@cremor the issue can be tied to at most one page. I created and closed #15165 - which shows up on the closed issues tab of that page. Feel free to edit that closed issue.

@jkone27
Copy link

jkone27 commented Aug 31, 2020

updates on this one? thorough and detailed documentation on OpenApiReference would be very much appreciated 👍

@Tim-Hodge
Copy link

Also looking for some updated docs on this - is OpenApiReference the recommended way for automated generation within csproj, or should I be looking elsewhere?

@Rick-Anderson
Copy link
Contributor Author

Thank you for contacting us. Due to a lack of activity on this discussion issue we're closing it in an effort to keep our backlog manageable. If you believe there is a concern which hasn't been addressed, please file a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-mvc doc-enhancement Pri1 Source - Docs.ms Docs Customer feedback via GitHub Issue
Projects
None yet
Development

No branches or pull requests