Bump NSwag and Swashbuckle package versions #12950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- current and next versions - will need to bump versions again to pick up latest Microsoft-provided features
- lots of renames and type changes (especially `string` -> `Uri`) in NSwag - Swashbuckle now relies on Microsoft.OpenApi.Models - disable OpenAPI doc generation in other .NET Core 2.0 project
- NSwag and Swashbuckle now use common `Startup` namespaces such as Microsoft.AspNetCore.Builder nit: sort `using`s
dougbu
commented
Jun 19, 2019
| @@ -13,7 +13,7 @@ This article highlights the most significant changes in ASP.NET Core 2.2, with l | |||
|
|
|||
There was a problem hiding this comment.
Note: I'm not updating the markdown headers because the changes primarily address nits.
Move solution file into samples folder
scottaddie
reviewed
Jun 20, 2019
| @@ -5,6 +5,12 @@ | |||
| <ProjectUISubcaption>NSwag - ASP.NET Core 2.0</ProjectUISubcaption> | |||
| </PropertyGroup> | |||
|
|
|||
| <!-- <snippet_NoDocumentGeneration> --> | |||
There was a problem hiding this comment.
Did you mean to import this snippet in the doc and say something about it?
There was a problem hiding this comment.
Prep for when our partner's packages support the doc gen feature and enabling / disabling it with this switch. I just happened to be testing w/ locally-build partner packages. So, no import yet.
| @@ -5,6 +5,12 @@ | |||
| <ProjectUISubcaption>Swashbuckle - ASP.NET Core 2.0</ProjectUISubcaption> | |||
| </PropertyGroup> | |||
|
|
|||
| <!-- <snippet_NoDocumentGeneration> --> | |||
There was a problem hiding this comment.
Another snippet that you probably meant to import into the doc.
scottaddie
approved these changes
Jun 21, 2019
|
Thank you for the PR, @dougbu! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nits: