Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for API description providers in web sites #8465

Open
dougbu opened this issue Sep 8, 2018 · 3 comments
Open

Add documentation for API description providers in web sites #8465

dougbu opened this issue Sep 8, 2018 · 3 comments
Labels
area-mvc doc-bug re-Safia @captainsafia must review
Milestone

Comments

@dougbu
Copy link
Member

dougbu commented Sep 8, 2018

General

#4896 includes (and the Microsoft.Extensions.ApiDescription.Client package will include) a generic tool that retrieves API descriptions from web sites. Though the tool can fire up the web site (in TestServer) and download the description from a URI, that requires site-specific configuration. The tool first attempts to get a service from DI and call a method on that service to get the API description. This issue is about documenting that service for providers (such as NSwag and Swagger) with packages extending web sites to generate API descriptions.

We plan to submit an example service implementation to the https://github.com/RSutor/NSwag repo but not to do the same for (say) Swashbuckle. Further, that example will not (cannot) cover the various options providers have w.r.t. the service name, method name, or method signature. Other providers will thus require documentation of how to work with the new tool.

Requests for new Topics

Topic will cover requirements for implementing an Microsoft.Extensions.ApiDescriptions.IDocumentProvider service and how that service will be invoked. (Note: IDocumentProvider is just a name the service uses to activate the service. We won't include a definition of the interface in any Microsoft package. Providers may choose from a number of method signatures and, therefore, concrete interfaces.)

Contents

Placement

Should probably go close to the documentation added in #8461

CC

@glennc

@dougbu
Copy link
Member Author

dougbu commented Jun 11, 2019

@glennc given the low number of OpenAPI document providers, how important is this documentation for our partners i.e. is it really a P1 (@scottaddie's suggestion) or P2 (@danroth27's suggestion)?

@dougbu
Copy link
Member Author

dougbu commented Jul 19, 2019

Discussed offline w/ @glennc. This issue should be addressed for the benefit of the ecosystem, including partners who choose not to interact with Microsoft directly.

@mkArtakMSFT
Copy link
Member

This will be a good 5.0 issue.

@Rick-Anderson Rick-Anderson added the re-Safia @captainsafia must review label Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-mvc doc-bug re-Safia @captainsafia must review
Projects
None yet
Development

No branches or pull requests

6 participants