Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation to support code generator MSBuild #8461

Open
dougbu opened this issue Sep 7, 2018 · 5 comments
Open

Add documentation to support code generator MSBuild #8461

dougbu opened this issue Sep 7, 2018 · 5 comments
Labels
Milestone

Comments

@dougbu
Copy link
Member

dougbu commented Sep 7, 2018

General

dotnet/aspnetcore#4896 includes a number of extension points for code and document generator providers. We plan to submit example extensions to the https://github.com/RSutor/NSwag repo but not to do the same for (say) Swashbuckle or AutoRest. Owners of other generators will thus require documentation of how to work with the coming Microsoft.Extensions.ApiDescription.Client package.

Requests for new Topics

Topic will cover requirements for implementing BlahDocumentGenerator, BlahCSharpCodeGenerator and BlahTypeScriptCodeGenerator targets, how those targets will be invoked, and suggested package dependencies. See RicoSuter/NSwag#1587 for example; that issue covers creating a package containing NSwagCSharpCodeGenerator and NSwagTypeScriptCodeGenerator targets. (RicoSuter/NSwag#1588 covers implementing the BlahDocumentGenerator target but the pattern is identical.)

Contents

Placement

This documentation doesn't really belong in the "Building Web APIs" tutorial and it's not clear to me where those wishing to extend ASP.NET Core would look first. Perhaps we need a new "chapter" providing guidance for those extending the framework?

CC

@glennc

@Rick-Anderson
Copy link
Contributor

@scottaddie is any of this completed?

@scottaddie
Copy link
Member

@Rick-Anderson No. Looks like the engineering work is still in progress. I've updated Doug's description with the updated issue.

@dougbu
Copy link
Member Author

dougbu commented Jun 11, 2019

@glennc given the low number of code generators, how important is this documentation for our partners i.e. is it really a P1?

@dougbu dougbu changed the title Add documentation to support code and document generator tooling Add documentation to support code generator MSBuild Jun 11, 2019
@dougbu
Copy link
Member Author

dougbu commented Jun 11, 2019

Reframed to more closely align with #8465

@dougbu dougbu removed this from the 3.0.0-preview6 milestone Jun 12, 2019
@Rick-Anderson Rick-Anderson added this to the Backlog milestone Jun 16, 2019
@dougbu
Copy link
Member Author

dougbu commented Jul 19, 2019

Discussed offline w/ @glennc. This issue should be addressed for the benefit of the ecosystem, including partners who choose not to interact with Microsoft directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants