Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend proposed ASP.NET Core's MSBuild code generation features using aspnetcore2swagger #1588

Closed
dougbu opened this issue Sep 7, 2018 · 3 comments

Comments

@dougbu
Copy link
Contributor

dougbu commented Sep 7, 2018

The overall aim of in-progress work in ASP.NET Core 2.2 is to give customers simple ways to annotate their project files for automated code generation during every build (as source API descriptions change). See ASP.NET Core Mvc's feature/client.code.generation branch and the aspnet/Mvc#7947 high-level issue.

The ASP.NET Core work will include a generic document generator tool supporting services in DI similar to that proposed in #313. This tool also supports downloading an API description from a specified URI of a running project. However, it does not support web sites without pre-existing API description capabilities. The aspnetcore2swagger command supports that case.

The ASP.NET Core Microsoft.Extensions.ApiDescription.Client package will include hooks supporting additional document generator tools. This issue is about using those hooks in the proposed (see #) NSwag.ApiDescription.Client package (name not yet final).

Specific work in this repo would include only the MSBuild extensions to the .targets file mentioned in # necessary to wrap the aspnetcore2swagger command as a NSwagDocumentGenerator target.

@dougbu
Copy link
Contributor Author

dougbu commented Sep 7, 2018

Work on this issue is blocked until #1587 is done

@dougbu
Copy link
Contributor Author

dougbu commented Nov 21, 2018

Work on this issue is blocked until #1587 is done

Not blocked because #1659 addresses this issue as well as #1587

RicoSuter pushed a commit that referenced this issue Nov 27, 2018
* Add NSwag.MSBuild.CodeGeneration package
- #1587, #1588

* Correct typo in 01_Build.bat

* Use Microsoft.Extensions.ApiDescription.Design version from https://dotnet.myget.org
- see https://dotnet.myget.org/feed/aspnetcore-dev/package/nuget/Microsoft.Extensions.ApiDescription.Design
- version ranges don't work with preview releases, see NuGet/Home#912
- users need the [aspnetcore-dev](https://dotnet.myget.org/gallery/aspnetcore-dev) feed to get this package

* Revert part of "Add NSwag.MSBuild.CodeGeneration package"
- remove unnecessary files added in commit cf65d85.

* Add `netcoreapp2.2` support in NSwag.MSBuild.CodeGeneration.targets

* nit: add NSwag.MSBuild.CodeGeneration files to solution
- VS also automatically corrected the NSwag.AssemblyLoader.Tests project type in the solution

* Update version

* Update Microsoft.Extensions.ApiDescription.Design package version
- this preview package is available on NuGet.org
@dougbu
Copy link
Contributor Author

dougbu commented Nov 27, 2018

a174a2c

Thanks @RSuter!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants