-
Notifications
You must be signed in to change notification settings - Fork 25.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Razor Components/Blazor access modifiers #11897
Conversation
I'll let @danroth27 comment on this one 😄 |
@guardrex We should |
... and while ur answering ... add it here? I was about to move on to the EventCallback issue, and I think we should get this reviewed and merged before I dig into that one. I was planning to open a new issue for " |
@Rick-Anderson Let's go ahead. The samps run and the changes are fairly straightforward here. I need this one merged in order to get on to the EventCallback issue (aspnet/AspNetCore.Docs #11243). I opened Razor Components/Blazor [Parameter] attribute (aspnet/AspNetCore.Docs #11913) to deal with |
Sorry about my typo 😝. I was trying to say that instead of this: [Parameter] public string MyString { get; set; } We should at some point switch to this: [Parameter]
public string MyString { get; set; } |
@danroth27 Gotcha ... opened #11913 to address it. |
Fixes #11010
😅 Lot's 'o lines ... Took longer than I thought!
private
access modifier.👮♀️ Inconsistency Alert! 👮 We're using attributes (mostly) on the same line in RC/Blazor topics+samps but nowhere else (i.e., model attributes, attribute routing) in docs+samples.
Inconsistent but short ...
Consistent with docs+samples elsewhere but long ...
How do u want to play it? cc: @NTaylorMullen - Thoughts?