Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EventCallback content to Components topic+sample #11924

Merged
merged 3 commits into from
Apr 13, 2019

Conversation

guardrex
Copy link
Collaborator

@guardrex guardrex commented Apr 10, 2019

Fixes #11243

Internal Review Topic (EventCallback section)

  • For now, I focus on basic implementation. Let's add more detail where you think it's required from here.
  • Interesting bits are in the EventCallback section (a subsection of the Event handling section) and the accompanying sample updates for that content, which run lines 325-371 of aspnetcore/razor-components/components.md. The section is linked via the Internal Review Topic link. The rest of the updates here are general updates, and we can review those bits on the docs side.
  • Layouts! ... is there any way to use EventCallback/EventCallback<T> across a the component-layout barrier (i.e., affect the layout's objects from a component using the layout)?

@guardrex
Copy link
Collaborator Author

guardrex commented Apr 11, 2019

@rynowak Do u have time to look at the section on EventCallback?

If so, use the link ... it goes right to the important bits (the docs team can review the rest of this PR):

Internal Review Topic (EventCallback section)

This one should get u to the diff for line comments (lines 325-371):

https://github.com/aspnet/AspNetCore.Docs/pull/11924/files#diff-68aec1e5867e7fd4666f410fdf9b3a88

Nevermind, I'm good. 👍

aspnetcore/razor-components/components.md Outdated Show resolved Hide resolved
aspnetcore/razor-components/components.md Outdated Show resolved Hide resolved
aspnetcore/razor-components/components.md Show resolved Hide resolved
aspnetcore/razor-components/components.md Outdated Show resolved Hide resolved
aspnetcore/razor-components/components.md Outdated Show resolved Hide resolved
Copy link
Member

@rynowak rynowak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I read through this and everything here seems reasonable. if you want more stuff to mine, here's my original writeup on this topic dotnet/aspnetcore#6351

@guardrex
Copy link
Collaborator Author

guardrex commented Apr 13, 2019

@rynowak It is based on your remarks. I made it a little plainer on the latest commit.

@danroth27 It may require another touch (or two), but it seems to be heading in the right direction.

It's ready for another 👁️.

Also ... cleaned up that Parent component method name to just ShowMessage. That first name was a SillyRex™️ choice.

@guardrex guardrex merged commit e7cde85 into master Apr 13, 2019
@delete-merged-branch delete-merged-branch bot deleted the guardrex/eventcallback branch April 13, 2019 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document EventCallback
4 participants