Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WinAuth topic updates #12554

Merged
merged 3 commits into from
May 30, 2019
Merged

WinAuth topic updates #12554

merged 3 commits into from
May 30, 2019

Conversation

guardrex
Copy link
Collaborator

@guardrex guardrex commented May 27, 2019 •
edited
Loading

Fixes #12102
Fixes #12144

Internal Review Topic

  • Addresses content layout/organization problem. The changes here seek to adopt a start-to-finish section layout that should also clarify the difference between launch settings config and IIS/HTTP.sys host config.
  • Added a bit for HTTP.sys to cover for 3.0 host building.

Revised outline

  • Configure Windows Authentication in ASP.NET Core
    • Launch settings (debugger)
      • VS – New project and Existing project procedures
      • VSC/CLI – New project and Existing project procedures
    • Authentication services for IIS or HTTP.sys
      • IIS
        • Before publish with web.config
        • After publish with IIS Manager
      • HTTP.sys
    • Authorize users
      • Disallow anonymous access
      • Allow anonymous access
    • Impersonation
    • Claims transformations
    • Additional resources

@guardrex guardrex force-pushed the guardrex/winauth-updates branch from 5edab71 to 8b00898 Compare May 27, 2019 17:50
@guardrex guardrex requested a review from Tratcher May 28, 2019 16:35
@guardrex
Copy link
Collaborator Author

@scottaddie Ur 1st author on this ... do you want to look?

@guardrex guardrex removed the request for review from Tratcher May 29, 2019 20:41
@guardrex guardrex added the PU label May 29, 2019
@scottaddie scottaddie self-requested a review May 29, 2019 21:27
guardrex and others added 2 commits May 29, 2019 22:09
@guardrex @scottaddie
Apply suggestions from code review
c4979b9 
Co-Authored-By: Scott Addie <10702007+scottaddie@users.noreply.github.com>
@guardrex
React to feedback
fa011aa
@guardrex
Copy link
Collaborator Author

keeps the reader from guessing

We discussed on another PR not cluttering the topics with them. Namespaces are easy to find. However, the solution on the last commit removes the guesswork. I link right to it and call it out in text.

@scottaddie
Copy link
Member

@guardrex If that's what was discussed in another PR, then roll with it. I've been out of the loop.

@scottaddie scottaddie merged commit 210dd08 into master May 30, 2019
@delete-merged-branch delete-merged-branch bot deleted the guardrex/winauth-updates branch May 30, 2019 14:31
@guardrex
Copy link
Collaborator Author

@scottaddie Note WRT the merge ... The PU hasn't looked at these updates.

We could just ask them to look at the live topic and see if there are any probs. As you saw, the vast majority of the changes here are just in topic layout.

Alternatively, the merge could be reversed and we let them come on at the doc-a-thon and 👀.

@scottaddie
Copy link
Member

@guardrex We'll let them look at the doc-a-thon.

@guardrex
Copy link
Collaborator Author

Sure ... sounds good.

... and don't forget our readers in the meantime. lol

They know full well what to do when they see a 🐲 Rex Franken Doc™️ 🐲 ... it's a lot of pitchforks and torches coming my way if these topic revisions go wrong.

Tratcher
Tratcher reviewed May 31, 2019
View reviewed changes
Copy link
Member

@Tratcher Tratcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but clarifying the IIS scenarios would help.

aspnetcore/security/authentication/windowsauth.md

The **Web Application** template available via Visual Studio or the .NET Core CLI can be configured to support Windows Authentication.
Configuration for launch settings only affects the *Properties/launchSettings.json* file and doesn't configure the IIS or HTTP.sys server for Windows Authentication. Configuration of the server is explained in the [Enable authentication services for IIS or HTTP.sys](#authentication-services-for-iis-or-httpsys) section.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So what does it affect? (IIS Express)

aspnetcore/security/authentication/windowsauth.md

Depending on the hosting scenario, follow the guidance in **either** the [IIS](#iis) section **or** [HTTP.sys](#httpsys) section.

### IIS
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And Express?
In-proc and out-of-proc?

@guardrex
Copy link
Collaborator Author

@Tratcher I'll open a new issue with those remarks and work it asap. Although I had the "PU" label on this, I should have said something in the comments.

@guardrex guardrex mentioned this pull request May 31, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tratcher Tratcher Tratcher left review comments

@scottaddie scottaddie scottaddie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@guardrex @scottaddie @Tratcher