Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Surface Worker Service project template #12665

Merged
merged 2 commits into from
Jun 4, 2019
Merged

Conversation

guardrex
Copy link
Collaborator

@guardrex guardrex commented Jun 3, 2019

Fixes #11791

btw - In the WS topic, I tried a version of this where the IDE instructions are under item 1 in the two-item list. It renders with a full-width horizontal rule under the list item that I'm not happy about. Therefore, I list the two steps and then show the IDE instructions.

@guardrex guardrex requested a review from tdykstra June 3, 2019 22:16
Copy link
Contributor

@tdykstra tdykstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

aspnetcore/fundamentals/host/hosted-services.md Outdated Show resolved Hide resolved
aspnetcore/host-and-deploy/windows-service.md Outdated Show resolved Hide resolved
Co-Authored-By: Tom Dykstra <tdykstra@microsoft.com>
@dotnet-bot
Copy link

Docs Build status updates of commit 6119184:

✅ Validation status: passed

File Status Preview URL Details
aspnetcore/fundamentals/host/hosted-services.md ✅Succeeded View (>= aspnetcore-1.0)
aspnetcore/host-and-deploy/windows-service.md ✅Succeeded View (>= aspnetcore-1.0)

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@guardrex guardrex merged commit 80eacc4 into master Jun 4, 2019
@delete-merged-branch delete-merged-branch bot deleted the guardrex/ws-project-template branch June 4, 2019 16:02
@@ -21,6 +21,35 @@ An ASP.NET Core app can be hosted on Windows as a [Windows Service](/dotnet/fram
* [ASP.NET Core SDK 2.1 or later](https://dotnet.microsoft.com/download)
* [PowerShell 6.2 or later](https://github.com/PowerShell/PowerShell)

::: moniker range=">= aspnetcore-3.0"

## Worker Service template
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guardrex if this is duplicated content, should I move it to an include?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, not just yet ... not until I get to #12841. IIRC, the light coverage on this template was provided just to surface its existence at the time. I have a feeling that that these two topics (background tasks and WS) aren't going to say the same thing about the use of the template, so an INCLUDE might not work out. Not sure ... I need to get to that issue and analyze the coverage and see what's what.

@Rick-Anderson
Copy link
Contributor

We should put the info in one place, be it an include or a link to another topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Surface 3.0 Windows service project template in WS topic
4 participants