Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hosting:core module config #1285

Merged
merged 1 commit into from
Jun 2, 2016
Merged

hosting:core module config #1285

merged 1 commit into from
Jun 2, 2016

Conversation

Rick-Anderson
Copy link
Contributor

No description provided.

@Rick-Anderson
Copy link
Contributor Author

@shirhatti config needs to live it it's own doc. Please review.

@shirhatti
Copy link
Contributor

@Rick-Anderson I just made a couple of changes. Please review

@Rick-Anderson
Copy link
Contributor Author

@shirhatti looks great. Can you give me the squirrel?

@shirhatti
Copy link
Contributor

I thought you are going to add in the app_offline stuff as well?

@Rick-Anderson
Copy link
Contributor Author

@shirhatti sorry, added app_offline (#1189 wasn't linked to this).

@Rick-Anderson
Copy link
Contributor Author

@shirhatti add note you must create log file and app_offline. Anything else?

@Rick-Anderson
Copy link
Contributor Author

@shirhatti added note you must create log file and app_offline. Anything else?

guardrex
guardrex reviewed May 29, 2016
View reviewed changes
aspnet/hosting/aspnet-core-module.rst

By `Rick Anderson`_ and `Sourabh Shirhatti`_

In ASP.NET Core, the web application is hosted by an external process outside of IIS. The ASP.NET Core Module is an IIS 7.5+ module which is responsible for process management of ASP.NET Core http listeners and to proxy requests to processes that it manages. This document provides an overview of how to configure the ASP.NET Core Module for shared hosting of ASP.NET Core.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: extra space between "of" and "ASP.NET"

@guardrex
Copy link
Collaborator

I came to the party a little late, but I hope any of those little bits are useful. 😄

Happy Memorial Day! 🚀 🎸 ✈️ 🎉 🎈

@Rick-Anderson Rick-Anderson self-assigned this May 31, 2016
@shirhatti
Copy link
Contributor

@Rick-Anderson @danroth27 I made a couple more changes to configuration reference as well. I'm happy with the technical accuracy of the doc now.

I assume @Rick-Anderson will handle merging it in?

@Rick-Anderson
Copy link
Contributor Author

I'm happy with the technical accuracy of the doc now.

@shirhatti is that a squirrel?

@Rick-Anderson
Copy link
Contributor Author

@shirhatti I'll need help merging
D:\github\8\docs [rick-and-coremod-config ≡]> git rebase -i master
error: could not apply 6ac0715... hosting:core module config

When you have resolved this problem, run "git rebase --continue".
If you prefer to skip this patch, run "git rebase --skip" instead.
To check out the original branch and stop rebasing, run "git rebase --abort".
Could not apply 6ac0715... hosting:core module config

@rachelappel rachelappel force-pushed the rick-and-coremod-config branch from 8afcd03 to d394ebf Compare June 2, 2016 18:14
@rachelappel rachelappel merged commit d394ebf into master Jun 2, 2016
@Rick-Anderson Rick-Anderson deleted the rick-and-coremod-config branch June 4, 2016 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Rick-Anderson Rick-Anderson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Rick-Anderson @shirhatti @guardrex @Tratcher @rachelappel @dnfclas