Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hosted Services updates for 3.0 #14417

Merged
merged 1 commit into from
Sep 23, 2019
Merged

Conversation

guardrex
Copy link
Collaborator

@guardrex guardrex commented Sep 19, 2019

Fixes #14381
Fixes #12841

Internal Review Topic

  • Whole topic versioning.
  • Thanks @manigandham ... In your honor, the official example calls out the VideosWatcher 👀.
  • New 3.0 sample.
    • Based on the new Worker Service template, and we can add the VS4Mac instructions now.
    • Nice upgrades to the sample thanks to anurse advice. 💵 In Nurse We Trust™️ 💵 🍻
  • Let's drop the 2.x Generic Host sample. That was just a demo (i.e., never linked into the topic), and the Generic Host has churned quite a bit since 2.x. I don't think we should show that at all.
  • Let's not have a 3.x Web Host-based sample.

Note: In VSC's external terminal, the sample does respond to keystrokes to add queued work items. However, the app doesn't respond to Ctrl+C. It used to work when the 2.x sample was created and Ctrl+C works in a command shell for this 3.x app, but there's been a VSC regression somewhere along the way. I'll open an issue with VSC to investigate.

@analogrelay
Copy link
Contributor

In Nurse We Trust

Benedict Cumberbatch, playing Sherlock Holmes, is wearing a suit and top hat. He looks at a person off-camera and tips his hat

@guardrex
Copy link
Collaborator Author

guardrex commented Sep 23, 2019

@anurse Update on the Ctrl+C and UseConsoleLifetime situation: I just opened microsoft/vscode#81322. We're ok to proceed on the PR because I tell readers to run the sample app in a command shell. I'm going to open a new issue in a sec connected to that VSC issue to fix this up later when we get a final answer/solution.

[EDIT] Our tracking issue is open now at #14489.

@guardrex
Copy link
Collaborator Author

@anurse Do you still need time to look this over, or should I go ahead and call for docs team review?

@analogrelay
Copy link
Contributor

I think I'm happy with it

@guardrex
Copy link
Collaborator Author

I think I'm happy with it

@anurse I informed our docs management that plausible deniability is an important characteristic of the documentation process that might be used in certain cases where deliberations lead to the apparent need for qualitative distinctions that can't be potentially dealt with under ephemeral circumstances and the underlying complexities of the subject being described can't be completely adjudicated clearly at the time said subject was addressed.

They were very happy with that position and embraced it wholeheartedly. We're all good. 👍

So ......... @Rick-Anderson ... We're ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants