-
Notifications
You must be signed in to change notification settings - Fork 25.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tutorial samples #15924
Update tutorial samples #15924
Conversation
@eslam-fakhry unfortunately we can't remove any prior versions. We usually do the following to add a new version
|
@Rick-Anderson Updated the pull request |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one @eslam-fakhry! 🎸 We all thank you for helping.
You may already know this: If you flip this over to the diff, you can add all of my suggestions to one batch and then commit the single batch of changes all at once.
aspnetcore/security/authentication/add-user-data/sample-3.0/Areas/Identity/Data/WebApp1User.cs
Outdated
Show resolved
Hide resolved
...ity/authentication/add-user-data/sample-3.0/Areas/Identity/Pages/Account/Manage/Index.cshtml
Outdated
Show resolved
Hide resolved
...ity/authentication/add-user-data/sample-3.0/Areas/Identity/Pages/Account/_ViewImports.cshtml
Outdated
Show resolved
Hide resolved
...core/security/authentication/add-user-data/sample-3.0/Areas/Identity/Pages/_ViewStart.cshtml
Outdated
Show resolved
Hide resolved
aspnetcore/security/authentication/add-user-data/sample-3.0/appsettings.json
Outdated
Show resolved
Hide resolved
Co-Authored-By: Luke Latham <1622880+guardrex@users.noreply.github.com>
Modify code-cshtml to code-csharp for cs snippets
Limit the line lengths in the displayed snippets
Remove extra spaces Co-Authored-By: Luke Latham <1622880+guardrex@users.noreply.github.com>
…NetCore.Docs into update-tutorial-samples
@eslam-fakhry can you fix the merge conflicts in aspnetcore/security/authentication/add-user-data/sample-2.2/Areas/Identity/Pages/Account/Manage/Index.cshtml ? |
Thanks for doing all of this work 😅. I'll note this PR on the tracking issue at #5495. |
…to update-tutorial-samples
I'll go ahead and sign-off. Some of the lines might be too long if those lines are used in the topic ... the long ones might just be code that isn't shown tho. I'll add the internal tracking link to your opening comment. That will indicate if there are any horizontal scrollbars. Thanks again for all of your hard work on this. I realize it's a lot, but this topic+sample will be easy to work with now (e.g., 3.1 ... coming soon!) ... thanks to YOU! 🎸 |
Lines look good. Thanks @eslam-fakhry |
Fixes #13232
Update "Add, download, and delete custom user data to Identity in an ASP.NET Core project" tutorial to use dotnet3.0
[EDIT by guardrex to add the internal review link]
Internal Review Link