Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update kestrel.md #17199

Merged
merged 2 commits into from
Mar 5, 2020
Merged

Update kestrel.md #17199

merged 2 commits into from
Mar 5, 2020

Conversation

Rick-Anderson
Copy link
Contributor

@Rick-Anderson Rick-Anderson commented Mar 4, 2020 •
edited
Loading

Address preliminary doc portion of dotnet/aspnetcore#14134

@Daniel15 please review.

@Daniel15
Copy link
Contributor

Daniel15 commented Mar 5, 2020 •
edited
Loading

Is this bug going to be fixed in a future ASP.NET release? The docs should probably mention that if so.

This doesn't actually fix dotnet/aspnetcore#14134, it just documents the bug.

@Rick-Anderson @Daniel15
Update aspnetcore/fundamentals/servers/kestrel.md
cce96b0 
Co-Authored-By: Daniel Lo Nigro <d@d.sb>
@Rick-Anderson Rick-Anderson requested a review from Tratcher March 5, 2020 03:43
@Rick-Anderson
Copy link
Contributor Author

@Daniel15 Thanks for the suggestion.

Is this bug going to be fixed in a future ASP.NET release?

@Tratcher will need to answer that

@Tratcher
Copy link
Member

Tratcher commented Mar 5, 2020

We're looking at it for 5.0.

@Rick-Anderson
Copy link
Contributor Author

@Tratcher Are you OK with this PR?

@Tratcher
Copy link
Member

Tratcher commented Mar 5, 2020

@anurse, I'm going dark.

@analogrelay
Copy link
Contributor

I'll take a look.

@Rick-Anderson Rick-Anderson marked this pull request as ready for review March 5, 2020 18:41
@Rick-Anderson Rick-Anderson merged commit 9addd88 into master Mar 5, 2020
@Rick-Anderson Rick-Anderson deleted the Rick-Anderson-patch-6 branch March 5, 2020 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Daniel15 Daniel15 Daniel15 left review comments

@analogrelay analogrelay analogrelay approved these changes

@Tratcher Tratcher Awaiting requested review from Tratcher

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Rick-Anderson @Daniel15 @Tratcher @analogrelay