Add doc for testing ASP.NET Core middleware with TestServer #18114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Organizational nit
guardrex
force-pushed
the
guardrex/test-middleware
branch
from
c64e9b7 to
8d95949
Compare
Tratcher
reviewed
May 4, 2020
|
@Tratcher ... Try it now. I put some more 🥩 on the 🦴. btw- What's your metadata |
|
What's a metadata author entry supposed to have? |
|
Going by the pattern, I guess it's just our GH handle. I'm "guardrex," and RA is "rick-anderson" ... It should just be "tratcher" here. |
Tratcher
approved these changes
May 6, 2020
aspnetcore/test/middleware/samples_snapshot/3.x/false-failure-check.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Chris Ross <Tratcher@Outlook.com>
scottaddie
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16953
Internal Review Topic
author. I stuckcrossthere. What's the correct value?Assertlist is long in the 2nd example, I really like that ... I think that's a great educational show-'n-tell of a full set ofFACTchecks there. I think we should keep that.