Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cache in background #18295

Merged
merged 2 commits into from
May 14, 2020
Merged

Update cache in background #18295

merged 2 commits into from
May 14, 2020

Conversation

Rick-Anderson
Copy link
Contributor

@Rick-Anderson Rick-Anderson commented May 13, 2020 •
edited
Loading

@Rick-Anderson
Copy link
Contributor Author

@anurag-oss please review

anurag-oss
anurag-oss reviewed May 14, 2020
View reviewed changes
aspnetcore/performance/caching/memory.md Outdated
@@ -175,6 +175,10 @@ Using a <xref:System.Threading.CancellationTokenSource> allows multiple cache en
* Use <xref:Microsoft.Extensions.Caching.Memory.ICacheEntry.PostEvictionCallbacks> to set the callbacks that will be fired after the cache entry is evicted from the cache.
* For most apps, `IMemoryCache` is enabled. For example, calling `AddMvc`, `AddControllersWithViews`, `AddRazorPages`, `AddMvcCore().AddRazorViewEngine`, and many other `Add{Service}` methods in `ConfigureServices`, enables `IMemoryCache`. For apps that are not calling one of the preceding `Add{Service}` methods, it may be necessary to call <xref:Microsoft.Extensions.DependencyInjection.MemoryCacheServiceCollectionExtensions.AddMemoryCache*> in `ConfigureServices`.

## Background cache update

Use as [background service](xref:fundamentals/host/hosted-services) such as <xref:Microsoft.Extensions.Hosting.IHostedService> to update the cache. The background service can recompute the entries and then assign them to the cache only when they’re ready.
Copy link

@anurag-oss anurag-oss May 14, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probable typo. "Use a"

anurag-oss
anurag-oss reviewed May 14, 2020
View reviewed changes
aspnetcore/performance/caching/memory.md Outdated
@@ -342,6 +346,10 @@ Using a `CancellationTokenSource` allows multiple cache entries to be evicted as

* Use [PostEvictionCallbacks](/dotnet/api/microsoft.extensions.caching.memory.icacheentry.postevictioncallbacks#Microsoft_Extensions_Caching_Memory_ICacheEntry_PostEvictionCallbacks) to set the callbacks that will be fired after the cache entry is evicted from the cache.

## Background cache update

Use as [background service](xref:fundamentals/host/hosted-services) such as <xref:Microsoft.Extensions.Hosting.IHostedService> to update the cache. The background service can recompute the entries and then assign them to the cache only when they’re ready.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probable typo. "Use a"

@Rick-Anderson
Copy link
Contributor Author

@anurag-oss thanks for the review and original question. Fixed them both.

@Rick-Anderson Rick-Anderson merged commit 1365bdc into master May 14, 2020
@Rick-Anderson Rick-Anderson deleted the cache/refresh/ra branch May 14, 2020 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anurag-oss anurag-oss anurag-oss left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How to refresh the cache every X hours in the background.
2 participants
@Rick-Anderson @anurag-oss