IDisposable guidance for Transient and shared instances #18306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandondahler
approved these changes
May 16, 2020
guardrex
requested review from
mkArtakMSFT and
mjrousos
and removed request for
analogrelay,
davidfowl and
rynowak
|
@mkArtakMSFT @mjrousos ... if it helps move this one along, David gave the original remarks a 👍 at dotnet/extensions#1785 (comment). |
mjrousos
approved these changes
May 20, 2020
|
@javiercn given that you're driving a related conversation, do we want to make this update now, or wait till you come up with some resolution? |
|
Ping @javiercn ☝️ |
javiercn
approved these changes
Jun 1, 2020
|
@mjrousos ... I'm going to go ahead and get this in. If someone wants to float sample code, I'll drop it in later. I'm 🏃😅 trying to get caught up on Blazor issues for the next month ....... or two! 🏃🏃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17766
Fixes #17775
Internal Review Topic (links to new IDisposable guidance for Transient and shared instances section)
The new section appears twice ... 2.x and 3.x parts of the doc ... so you only need to review the first instance of the section. See 👉 Lines 454-487.
Thanks @brandondahler! 🎷