-
Notifications
You must be signed in to change notification settings - Fork 25.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't apply [Authorize] on page handler methods #18676
Conversation
@pranavkm quick review when you have time will save you time in the long run :) |
Sure, that would be great. |
Sorry @pranavkm I mean to add that. I got really ambitious on my last commit so you'll need another look and maybe @mkArtakMSFT too. I'm hoping what I've written will cut down on all that traffic on dotnet/aspnetcore#8737 |
@pranavkm I cloned https://github.com/pranavkm/PageHandlerAuth and copied the code to this repo. But on inspection, in dotnet/aspnetcore#8737 you show the code for your first commit. Just need to verify I need to copy over the code from your first commit. You 2nd commit is much different. |
|
||
|
||
[AttributeUsage(AttributeTargets.Method, AllowMultiple = false)] | ||
public class AuthorizePageHandlerAttribute : Attribute, IAuthorizeData |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I edited this to be more inline with what was shared in the issue (based on the initial commit). Could you move this to a new file? If you're able to try it out, that would be great. I edited this on GitHub, so I'm not sure if all this compiles \ works correctly.
…AspNetCore.Docs into rp/auth/page/handlers/ra
@blowdart please review Internal review URL and this PR. @mkArtakMSFT I added the following on my own, please approve:
|
Yeah, that seems fine to say. |
Co-authored-by: Pranav K <prkrishn@hotmail.com>
Fixes #18673
Internal review URL
@pranavkm Should I move your sample repo into the this repo?