Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HttpLogging docs #22101

Merged
merged 3 commits into from
Apr 30, 2021
Merged

Add HttpLogging docs #22101

merged 3 commits into from
Apr 30, 2021

Conversation

jkotalik
Copy link
Contributor

@jkotalik jkotalik commented Apr 21, 2021

Fixes dotnet/aspnetcore#31859

Still a WIP, but want to leverage CI for a few things I'm uncertain of.

@Rick-Anderson Edit MOVED TO #22103 - no commit here, do them in #22103

@jkotalik
Copy link
Contributor Author

@Rick-Anderson @guardrex most of the content is here now, can you help with polish?

@jkotalik
Copy link
Contributor Author

This is brand new for preview4, I'm not sure when API docs will be available for it.

@guardrex
Copy link
Collaborator

@Rick-Anderson ... I'm neck-deep 😨 in Blazor forms and validation bits at the moment, but I should be free Friday if you want me to take this one.

@jkotalik ... If I end up assisting, I'll open a follow-up issue for post 6.0 GA to take care of the API doc cross-links.

WRT the Cyberdine Systems Snippet Builder 5000 ... The build system isn't building with the preview SDK, so we'd end up merging without a passing build or alternatively upgrading to use the preview SDK.

@jkotalik
Copy link
Contributor Author

It doesn't need to happen today, but ideally before mid may 😄

@Rick-Anderson
Copy link
Contributor

I'll take care of it.

@Rick-Anderson
Copy link
Contributor

@jkotalik your writing is excellent. I'm pr'ing this PR in #22103, so you can see my changes. I can have it done by next week. I'm just getting started.

@Rick-Anderson Rick-Anderson changed the title Add HttpLogging docs See #22103 - don't push to this -Add HttpLogging docs Apr 23, 2021
* PR of jkotalik PR on HTTP logging

* PR of jkotalik PR on HTTP logging

* PR of jkotalik PR on HTTP logging

* clean up

* clean up

* clean up

* clean up

* clean up
@Rick-Anderson Rick-Anderson changed the title See #22103 - don't push to this -Add HttpLogging docs Add HttpLogging docs Apr 30, 2021
@Rick-Anderson Rick-Anderson marked this pull request as ready for review April 30, 2021 00:49
@Rick-Anderson Rick-Anderson merged commit b7f6f41 into main Apr 30, 2021
@Rick-Anderson Rick-Anderson deleted the jkotalik/requestLoggingDocs branch April 30, 2021 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HttpLogging Middleware documentation
3 participants