Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MS Graph SDK v5 guidance #28706

Merged
merged 7 commits into from
Mar 23, 2023
Merged

Add MS Graph SDK v5 guidance #28706

merged 7 commits into from
Mar 23, 2023

Conversation

guardrex
Copy link
Collaborator

@guardrex guardrex commented Mar 17, 2023

Addresses #28001
Fixes #28573

Thanks @cloudhal! 🚀 ... I'm still working on this. It's just a draft at the moment, while I work on a service registration problem with the custom account factory approach. I'll call for one of the product unit engineers to help if I can't figure it out.


Internal previews

📄 File 🔗 Preview link
aspnetcore/blazor/security/webassembly/graph-api.md aspnetcore/blazor/security/webassembly/graph-api

@guardrex
Copy link
Collaborator Author

guardrex commented Mar 17, 2023

Ok ... I think I figured it out 🎉. I should be able to wrap this up. I DO want to get the service registration reviewed. The service registration is a bit tricky this time around, just because the parameters must be passed to the Graph client when it's instantiated or else it 💥 up with a cryptic error about not being able to create an IRequestAdapter service for the Graph client.

... and I'm making an additional change to the whole topic. I don't think that splitting out the Graph client version makes sense. I'm rolling that back into the base URL out of configuration now.

UPDATE: I sent an email to Mackinnon to ask if he has any concerns about my factory service activation. It ✨ Just Works!™ ✨, so at least it has that going for it 😄. I'm going to perform a final review and update on this and hear back from him before merging. @cloudhal, if you have time to look this over, feedback is welcome. If not tho, no worries. Most of the updates here are of the general improvement variety.

@guardrex guardrex marked this pull request as ready for review March 17, 2023 12:45
@guardrex guardrex self-assigned this Mar 18, 2023
@guardrex guardrex merged commit 8c4546d into main Mar 23, 2023
@guardrex guardrex deleted the guardrex/blazor-graph-sdk branch March 23, 2023 11:53
Donciavas pushed a commit to Donciavas/AspNetCore.Docs that referenced this pull request Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update for Graph SDK 5.0
1 participant