-
Notifications
You must be signed in to change notification settings - Fork 25.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blazor QuickGrid coverage enhancements #28767
Conversation
This looks great @guardrex! I would suggest is adding that for people using EF IQueryables, we suggest installing the separate EDIT: Just noticed that the guidance doesn't say that Blargh, it looks like I didn't write the package description correctly either - https://www.nuget.org/packages/Microsoft.AspNetCore.Components.QuickGrid |
Thanks @Nick-Stanton ... WRT the package, that is versioned here, so that should be ok. I'll look it over one more time tomorrow to confirm. Specifically, I was told that it's going into the framework for .NET 8. In .NET 7, the package has to be added. Let me know if I didn't set that up correctly. Artak prompted me to set that guidance into place for .NET 8 (preview). .NET 8: https://learn.microsoft.com/en-us/aspnet/core/blazor/components/?view=aspnetcore-8.0#quickgrid-component WRT EF IQueryables, yes, I'll work that into the coverage. |
@Nick-Stanton ... Looking at the Basic Test App, it looks like the ... (and it's new for .NET 8) ... so it looks like the guidance won't need to mention adding a pkg ref for it. Let me know if that's incorrect. 👂 I'm going to I cross-link the Basic Test App. I do that in a number of spots around the docs. See if the latest updates do the trick, but look at the PR diff because it took a couple of attempts (commits) for me to the language correct in the right spots. |
I'm not sure we have specific tests for the EF IQueryables, which may need to be reevaluated. Here's an example of how it might be consumed from Steve's samples. https://aspnet.github.io/quickgridsamples/datasources The project reference looks a little funny here because it's referring to the version in the repo instead of from NuGet. FYI, I moved teams and am no longer working on Blazor. I'm happy to answer what I'm able to when I have time, but @SteveSandersonMS has deeper knowledge of how QG works. |
Sorry for the delay to reply, @Nick-Stanton ... I'm OOF for a few days. I'll get back to this later this week when I'm back on my feet. 🤒 |
I have a feel'in that that's going to be too point-in-time for us to document from. Those types of examples go stale and break. I think we can cross-link to the WRT ... builder.Services.AddQuickGridEntityFrameworkAdapter(); I see. Yes, I'll get that in here. ... and WRT the package reference, I see that I was incorrect about that from the following error language in the ref source (emphasis added) ...
|
@Nick-Stanton ... Thanks for your help. I made the updates. I'm going to submit another PR to split out this content into a new topic, and I'll ask Steve to review it later, asking him to take a look at all of the coverage and see if I left anything out and/or if he wants to cover anything differently. Thanks again for helping me with the updates. |
Addresses #28001
Addresses #28161
@Nick-Stanton, do you want to take a look at rough 8.0 draft coverage for
QuickGrid
? The coverage is a WIP 🚧 that I'll be picking back up with late next week, as I'm going to be OOF Monday thru Wednesday. I'll probably merge this now but come back with another PR late next week. If you don't have time to provide feedback now but will have time later, I can ping u on the next PR next week.Note in passing that we might want to have a more advanced example than this. However, we're linking to the QuickGrid for Blazor app, and that might be all we need to do for an advanced example.
Note also that this whole subject (section) might be better off in a dedicated topic. I'm really feel'in the idea because the Components overview article is already too long. I'm looking for ways to shorten the whole topic generally, and this would stand nicely as its own article in the Components node (folder). Yeah! The more I think about it, the more I LIKE IT! 😆 I'll split it out on the next PR tho, next week.
Internal previews