-
Notifications
You must be signed in to change notification settings - Fork 25.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hashed routing to named elements #29106
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
brb ... was pulled off on something else. 🏃 |
Co-authored-by: Surayya Huseyn Zada <114938397+surayya-MS@users.noreply.github.com>
@surayya-MS ... I feel we can flesh it out a bit more. See my last commit for what I think are improvements. btw ... Is the no leading forward slash for the self-links by design? Does |
No, both "/hashed-routing#targetElement" and "hashed-routing#targetElement" will work. |
I just realized that I did have the leading forward slash on the |
Ok ... this looks good. I'll merge it after it builds out. Thx for your help. |
Fixes #29105
Surayya ... I didn't guess about what general rules or gotchas 😈 that you want to call out. Let me know what you'd like to add in a comment, or you can
suggestion
them into the text.Internal previews