Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hashed routing to named elements #29106

Merged
merged 5 commits into from
Apr 28, 2023
Merged

Conversation

guardrex
Copy link
Collaborator

@guardrex guardrex commented Apr 27, 2023

Fixes #29105

Surayya ... I didn't guess about what general rules or gotchas 😈 that you want to call out. Let me know what you'd like to add in a comment, or you can suggestion them into the text.


Internal previews

📄 File 🔗 Preview link
aspnetcore/blazor/fundamentals/routing.md ASP.NET Core Blazor routing and navigation

Copy link
Member

@surayya-MS surayya-MS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

aspnetcore/blazor/fundamentals/routing.md Outdated Show resolved Hide resolved
aspnetcore/blazor/fundamentals/routing.md Show resolved Hide resolved
@guardrex
Copy link
Collaborator Author

brb ... was pulled off on something else. 🏃

guardrex and others added 2 commits April 27, 2023 13:19
Co-authored-by: Surayya Huseyn Zada <114938397+surayya-MS@users.noreply.github.com>
@guardrex
Copy link
Collaborator Author

guardrex commented Apr 28, 2023

@surayya-MS ... I feel we can flesh it out a bit more. See my last commit for what I think are improvements.

btw ...

Is the no leading forward slash for the self-links by design?

Does <a href="/hashed-routing#targetElement"> (with a / on it) 💥 at runtime? If so, we might want to work that into the coverage. If that doesn't break, I wonder if we should use it in the href cases for consistency with the Index and Counter component examples?

@surayya-MS
Copy link
Member

@surayya-MS ... I feel we can flesh it out a bit more. See my last commit for what I think are improvements.

btw ...

Is the no leading forward slash for the self-links by design?

Does <a href="/hashed-routing#targetElement"> (with a / on it) 💥 at runtime? If so, we might want to work that into the coverage. If that doesn't break, I wonder if we should use it in the href cases for consistency with the Index and Counter component examples?

No, both "/hashed-routing#targetElement" and "hashed-routing#targetElement" will work.

@guardrex
Copy link
Collaborator Author

I just realized that I did have the leading forward slash on the NavigateTo examples, at least in this topic. I'm going to note a tracking item to check the whole Blazor docs node and confirm consistent display later.

@guardrex
Copy link
Collaborator Author

Ok ... this looks good. I'll merge it after it builds out. Thx for your help.

@guardrex guardrex merged commit 16240d8 into main Apr 28, 2023
@guardrex guardrex deleted the guardrex/blazor-hashed-routing branch April 28, 2023 10:57
Donciavas pushed a commit to Donciavas/AspNetCore.Docs that referenced this pull request Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hash routing to named element
2 participants