Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SupplyParameterFromQuery 8.0 updates #29705

Merged
merged 2 commits into from
Jul 7, 2023

Conversation

guardrex
Copy link
Collaborator

@guardrex guardrex commented Jul 5, 2023

Fixes #29547

Mackinnon ...

  • We never documented [SupplyParameterFromForm] for any release. I thought it was an internal framework API bit that devs wouldn't directly use, but I'm prepared to hear what we need to cover it if that's not the case. 👂
  • This is the only spot in the Blazor docs that we cover the [SupplyParameterFromQuery] attribute. If there are no other places around the Blazor docs that need to refer to the attribute, then we'll be good to go after we get this spot updated.
  • Although Pre6 isn't out yet, I'm going to merge this after you sign off. I'm already working on the major updates for full-stack Blazor, and I don't want to get bogged down in a 😈 nasty merge conflict 😈 situation 😆.

Internal previews

📄 File 🔗 Preview link
aspnetcore/blazor/fundamentals/routing.md ASP.NET Core Blazor routing and navigation

Copy link
Member

@MackinnonBuck MackinnonBuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I think this is still the only spot where we need to document [SupplyParameterFromQuery].

Regarding [SupplyParameterFromForm], the reason we haven't documented it for previous releases is that it's a very new feature 🙂 Its use is somewhat similar to that of [SupplyParameterFromQuery], but it binds parameters to form request entries rather than query parameters. I would suggest content about [SupplyParameterFromForm] should be added to the "Forms and Input Components" document rather than the routing docs, where [SupplyParameterFromQuery] is documented.

Issues describing the design of this feature can be found here and here. Some usage examples can be found in our test components. If this isn't the right info (or not enough info) for you to get started preparing content, please let me know!

CC @javiercn in case you have anything to add.

@guardrex guardrex merged commit 4deb4f5 into main Jul 7, 2023
@guardrex guardrex deleted the guardrex/blazor-supplyparameterfromquery-net8 branch July 7, 2023 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update [SupplyParameterFromQuery] guidance and examples
2 participants