Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Blazor WASM compression flag #30214

Merged
merged 2 commits into from
Sep 1, 2023
Merged

Change Blazor WASM compression flag #30214

merged 2 commits into from
Sep 1, 2023

Conversation

LostBeard
Copy link
Contributor

@LostBeard LostBeard commented Sep 1, 2023

Corrected documentation to reflect the compression flag name change from BlazorEnableCompression to CompressionEnabled as described here dotnet/aspnetcore#50451 (comment)

Fixes #30213


Internal previews

📄 File 🔗 Preview link
aspnetcore/blazor/host-and-deploy/webassembly.md Host and deploy ASP.NET Core Blazor WebAssembly

Corrected documentation to reflect the compression flag name change from BlazorEnableCompression to CompressionEnabled as described here dotnet/aspnetcore#50451
@guardrex guardrex self-assigned this Sep 1, 2023
@guardrex guardrex changed the title Update webassembly.md to reflect flag name change from BlazorEnableCompression to CompressionEnabled Change Blazor WASM compression flag Sep 1, 2023
@guardrex
Copy link
Collaborator

guardrex commented Sep 1, 2023

Thanks for this, @LostBeard. Indeed, it wasn't on the 8.0 roadmap, so it wasn't tracked for doc updates. When I hear back from Mackinnon on what version the change applies to, I can proceed with the versioning of the guidance.

@guardrex
Copy link
Collaborator

guardrex commented Sep 1, 2023

@MackinnonBuck ... I need to confirm that the change for MS Build property <BlazorEnableCompression> to <CompressionEnabled> is only for >=8.0.

@LostBeard
Copy link
Contributor Author

Ah. I just tested .Net 6 and .Net 7 BlazorWASM projects and the flag has changed to CompressionEnabled in both of those versions also.

@guardrex
Copy link
Collaborator

guardrex commented Sep 1, 2023

Depends on how you test. Can't merely target the app's framework. I think the vintage SDK has to be used.

Javier just said 'Yes" to the question I deleted there about it only applying to the .NET 8 or later SDK. dotnet/aspnetcore#50451 (comment)

Copy link
Collaborator

@guardrex guardrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again, @LostBeard! 🚀

@LostBeard
Copy link
Contributor Author

@guardrex Ah. That is interesting. Thank you for the info and the update.

@guardrex guardrex enabled auto-merge (squash) September 1, 2023 16:08
@guardrex guardrex merged commit 512d76a into dotnet:main Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change Blazor WASM compression flag
2 participants