Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prerender and Integrate work (Round 1) #30455

Merged
merged 4 commits into from
Sep 25, 2023

Conversation

guardrex
Copy link
Collaborator

@guardrex guardrex commented Sep 25, 2023

Addresses #30341
Addresses #28161

Round 1 🥊😵💫

This will be at least a two-step process. I'm going to merge this one quickly to get out of the way on non-Blazor node updates (e.g., the ToC changes needed).

I'm just going to use the old skool Whole-topic Versioning approach without the INCLUDE because I'm not clear on naming/location for the extra content (in the INCLUDE) and slammed with work right now. I need to keep rolling with the Blazor updates 🏃😅. I'll leave it to others to structure this article later for the new Whole-topic approach, if desired.


Internal previews

Toggle expand/collapse
📄 File 🔗 Preview link
aspnetcore/blazor/components/index.md ASP.NET Core Razor components
aspnetcore/blazor/components/integration.md aspnetcore/blazor/components/integration
aspnetcore/blazor/components/layouts.md ASP.NET Core Blazor layouts
aspnetcore/blazor/components/lifecycle.md ASP.NET Core Razor component lifecycle
aspnetcore/blazor/components/prerendering-and-integration.md Prerender and integrate ASP.NET Core Razor components
aspnetcore/blazor/components/prerendering.md aspnetcore/blazor/components/prerendering
aspnetcore/blazor/fundamentals/signalr.md aspnetcore/blazor/fundamentals/signalr
aspnetcore/blazor/host-and-deploy/multiple-hosted-webassembly.md Multiple hosted ASP.NET Core Blazor WebAssembly apps
aspnetcore/blazor/security/index.md ASP.NET Core Blazor authentication and authorization
aspnetcore/blazor/security/webassembly/index.md Secure ASP.NET Core Blazor WebAssembly
aspnetcore/fundamentals/url-rewriting.md aspnetcore/fundamentals/url-rewriting
aspnetcore/migration/30-to-31.md Migrate from ASP.NET Core 3.0 to 3.1
aspnetcore/migration/70-80.md [Visual Studio](https://review.learn.microsoft.com/en-us/aspnet/core/migration/70-80?branch=pr-en-us-30455)
aspnetcore/mvc/overview.md Overview of ASP.NET Core MVC
aspnetcore/mvc/views/tag-helpers/built-in/component-tag-helper.md Component Tag Helper in ASP.NET Core
aspnetcore/mvc/views/tag-helpers/built-in/persist-component-state.md Persist Component State Tag Helper in ASP.NET Core
aspnetcore/mvc/views/view-components.md aspnetcore/mvc/views/view-components
aspnetcore/razor-pages/index.md Introduction to Razor Pages in ASP.NET Core
aspnetcore/release-notes/aspnetcore-3.1.md What's new in ASP.NET Core 3.1
aspnetcore/tutorials/choose-web-ui.md Choose an ASP.NET Core web UI

@guardrex
Copy link
Collaborator Author

@wadepickett ... One of the articles that you manage ...

aspnetcore/tutorials/choose-web-ui.md

... requires a few updates here. Do you want to review that one?

@guardrex guardrex self-assigned this Sep 25, 2023
@wadepickett
Copy link
Contributor

Looking it over... thanks!

@wadepickett
Copy link
Contributor

@guardrex, choose-web-ui.md changes look good! I'm also taking note of the terminology changes you made so that I am using those. I didn't review/approve for the entire PR since there are some areas I'm not going to be the best reviewer for, although I didn't notice anything amiss.

@guardrex
Copy link
Collaborator Author

Thanks. I'll be merging this now to avoid blocking other work (e.g., ToC updates by others).

For Round 2 🥊.................

terminator2

"I'll be back." - Cyberdyne Systems T-800 Series Model 101 (Arnold Schwarzenegger)
     The Terminator ©1984 Skydance Media

@guardrex
Copy link
Collaborator Author

... I'm also removing an old forum link that's a warning on the build. It's not a significant loss to just 🔪 it out.

@guardrex guardrex closed this Sep 25, 2023
@guardrex guardrex reopened this Sep 25, 2023
@guardrex
Copy link
Collaborator Author

@Rick-Anderson ... The license check seems broken. I performed the old "turn of off and back on" (i.e., close/re-open) with no effect.

@Rick-Anderson
Copy link
Contributor

@Rick-Anderson ... The license check seems broken. I performed the old "turn of off and back on" (i.e., close/re-open) with no effect.

It's not the first time. Merge away.

@guardrex
Copy link
Collaborator Author

It will only allow me to set up auto-merge, and I don't think these necessarily clear without a close/re-open cycle, so I don't think auto-merge will be much help.

@guardrex guardrex closed this Sep 25, 2023
@guardrex guardrex reopened this Sep 25, 2023
@Rick-Anderson Rick-Anderson merged commit 9328f3d into main Sep 25, 2023
3 checks passed
@Rick-Anderson Rick-Anderson deleted the guardrex/blazor-prerender-integratation branch September 25, 2023 19:46
@guardrex
Copy link
Collaborator Author

🎉🍻

Thanks, @Rick-Anderson!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants