Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blazor migration guidance 8.0 #30671

Merged
merged 20 commits into from
Oct 20, 2023
Merged

Blazor migration guidance 8.0 #30671

merged 20 commits into from
Oct 20, 2023

Conversation

@guardrex guardrex self-assigned this Oct 12, 2023
@guardrex guardrex marked this pull request as ready for review October 17, 2023 14:32
@guardrex
Copy link
Collaborator Author

guardrex commented Oct 17, 2023

@robertmclaws ... Standalone WASM doesn't require more than the first three main doc updates (global.json, framework, packages), and there's a short section to call that out now.

There's hosted WASM guidance now. I only just typed it out this morning ... and it's missing some content for guidance on prerendered components ... and there are bound to be some 😈😈😈 in it.

We'll iron out the coverage shortly ... today ... tomorrow ... soon 🏃😅.

WRT your remark ...

create a new app and copy the code over

If you want every bleed'in update 😆 ... then Yes! That's the guidance, and it probably always will be the guidance. Only once did I write out every single line change required for an update (back for the 5.0 release), and it was a 😈 living daymare 😈 to write, follow, and maintain ... perfect for 🎃 Halloween 🧟‍♂️! 😆 I don't think we'll ever try to do that again. Make a new project, move the bits ... components/pages with mods for new features ... update the layout/styles ... 🎤 drop ... Done! 😄 That's our recommendation for devs who want every little update that was made for project templates.

As for adding some additional changes to the scenarios on the PR, Yes! We're going to take a look at that right now on review. What's on the PR are the minimum steps required to update to 8.0, making it possible to then adopt the new 8.0 features. We'll see if there's anything else that DR and Artak would like to add to the steps taking the resultant app closer to a BWA. Stand-by for their reviews ...........................

guardrex and others added 5 commits October 19, 2023 08:14
Co-authored-by: Daniel Roth <daroth@microsoft.com>
guardrex and others added 2 commits October 19, 2023 12:59
Co-authored-by: Daniel Roth <daroth@microsoft.com>
Co-authored-by: Daniel Roth <daroth@microsoft.com>
Copy link
Member

@danroth27 danroth27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we split the integration article updates into a separate PR so we can get the migration content merged in? The migration content looks pretty much ready to go, but I want to work on the integration content some more.

guardrex and others added 2 commits October 20, 2023 07:14
Co-authored-by: Daniel Roth <daroth@microsoft.com>
@guardrex
Copy link
Collaborator Author

split the integration article updates into a separate PR

Yes, I'll press the Easy button on that and merely comment out the new content in the Integration article. I'll wrap this up now and open a new PR, where we can pick back up with the coverage.

@guardrex guardrex merged commit afeb0a6 into main Oct 20, 2023
2 checks passed
@guardrex guardrex deleted the guardrex/blazor-migration branch October 20, 2023 11:27
@shrayasr
Copy link

@guardrex : please forgive me if this isn't the right place to voice this, but given that this PR is the one that made the migration, I thought it best to write here.

Allow me to set some context first. We are heavily invested in Blazor but we had to take a pause because of the incomplete auth story. I tweeted this out and @danroth27 kindly responded asking me to check if it was fixed in NET8. And it has been! So we're back on the Blazor bandwagon now.

However while we were upgrading, we saw the following suggestion

- app.MapBlazorHub();
+app.MapRazorComponents<App>()
+   .AddInteractiveServerRenderMode()

And we're kind of stuck here since our previous call to MapBlazorHub looked like this:

endpoints.MapBlazorHub(config =>
{
    config.CloseOnAuthenticationExpiration = true;
});

And we're unable to find out where we should be moving the CloseOnAuthenticationExpiration call to?

Is this something that you're able to help us with?

Cheers and thanks for all the great work!

@guardrex
Copy link
Collaborator Author

@shrayasr ... Open a new issue from the bottom of the Migration article because you have raised an excellent point about passing configuration options to the extension methods. I agree that we need coverage.

I recommend titling the issue:

Add Blazor migration guidance on service/endpoint configuration

For the text, copy and paste the remarks you just made into the opening comment.

@shrayasr
Copy link

Thanks for the super fast response @guardrex. I have done as per your advise. Issue is here: #30843

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants