Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve auth state provider guidance #31503

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

guardrex
Copy link
Collaborator

@guardrex guardrex commented Jan 18, 2024

Fixes #31496

@surayya-MS ... Ignore my ping. I just found out that you joined a different team.

Thanks @PMcVries! 🚀 ... This isn't the end of the story. There's a lot more work to do on BWA security. This at least calls out Surayya's suggestion to take an approach similar to what the BWA template does. I have a tracking work item separate from your issue to work further on this node of docs, and I'll get to it as soon as I can 🏃‍♂️🏃‍♂️🏃‍♂️🏃‍♂️🏃‍♂️🏃‍♂️🏃‍♂️🏃‍♂️.

Mackinnon, I stole 🚓👮 Surayya's remarks from dotnet/aspnetcore#52317 (comment) to get this coverage going. I don't have the workaround described at dotnet/aspnetcore#52317 (comment) because it sounds like it isn't the best way to manage the scenario. However, I can add it to this if you like, or I can cross-link to the PU issue (e.g., For more information, see XXXXXX.).


Internal previews

📄 File 🔗 Preview link
aspnetcore/blazor/security/server/index.md Secure ASP.NET Core server-side Blazor apps

@guardrex guardrex self-assigned this Jan 18, 2024
@guardrex guardrex requested review from surayya-MS and MackinnonBuck and removed request for surayya-MS January 18, 2024 17:57
Copy link
Member

@MackinnonBuck MackinnonBuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small question, but other than that, LGTM!

Comment on lines +178 to +181
*This section applies to Blazor Web Apps that adopt:*

* *Interactive server-side rendering (interactive SSR) and CSR.*
* *Client-side rendering (CSR).*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these acronyms used elsewhere? I haven't seen them before.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, right from the start ...

https://learn.microsoft.com/en-us/aspnet/core/blazor/components/render-modes?view=aspnetcore-8.0

Set up in consultation with Dan. Based on his remarks about industry use, "client-side rendering"/"CSR" doesn't get the "interactive" word applied, and there's an dagger remark there under the table to call that out ☝️.

I always spell these out (static SSR/interactive SSR) first in a section (e.g., "interactive server-side rendering (interactive SSR)"), and then I use "interactive SSR" throughout the section. I figured that "SSR" might be too cryptic for many devs and that it always should be spelled out initially before using the acronym.

@guardrex guardrex merged commit 416c85f into main Jan 19, 2024
2 checks passed
@guardrex guardrex deleted the guardrex/blazor-auth-state-providers branch January 19, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve auth state provider guidance for BWAs
2 participants