Transient "disposable" service language updates #31738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hakenr
reviewed
Feb 8, 2024
guardrex
commented
Feb 8, 2024
guardrex
commented
Feb 8, 2024
Let's try these updates ... and I'll take your "for" over "instead" suggestion now that I'm dropping the mention of disposable transient services from that sentence.
|
Hammered 🔨 that point home a bit harder with the latest updates, and I took your "for" over "instead" suggestion because I dropped the disposable transient language from that sentence in the third paragraph. |
hakenr
reviewed
Feb 8, 2024
MackinnonBuck
approved these changes
Feb 8, 2024
Co-authored-by: Mackinnon Buck <mackinnon.buck@gmail.com>
|
Thanks @MackinnonBuck and @hakenr. 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31726
Ok ... now we're cook'in with GAS! 🔥
Thanks @hakenr (and the HAVIT team) for sticking with this to the end 🥇. I included the link to the PU issue, and that makes sense given that it was punted back to .NET 10 for consideration.
Mackinnon: I'm assuming here that non-disposable transient services registered client-side are disposed correctly when the component is disposed, as they would be in the server-side case per Steve's remarks. Other than that, I think this closely matches what he said ... I stole 🦹 quite a bit of his language for these updates 👮🚓🚨 .
Internal previews