-
Notifications
You must be signed in to change notification settings - Fork 25.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New .NET MAUI Blazor Hybrid template #32793
New .NET MAUI Blazor Hybrid template #32793
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Some minor changes needed.
@BethMassi ... This will be a Texas Two-step operation. First, I'll merge your commits, then I'll see about a commit to deal with the |
Co-authored-by: Beth Massi <bethma@microsoft.com>
@BethMassi ... See if my last commit resolves ...
|
... and BTW ... I will open a follow-up issue to make the 8.0 sample app match that. Then, I can go back in here later and nix the versioned content and use the new naming. |
Also, there was some kind of build failure on the prior commit. I'll check on that after this builds and see what broke it 💥. |
Ok ... I see the problem. I'll fix it. I had one too many versioning blocks, and the section name change broke a bookmark link. The next commit should fix it up. |
🎉Success! See how it looks now with the latest updates. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still see references to MauiBlazorWeb.Maui but as long as that is only for 8.0 that's OK I guess? It's hard to follow the conditional statements :-) so I trust you. I'd suggest just updating the .NET 8 sample to match the naming so it's easier.
Exactly! ... which is why I've been arguing for Version-by-File for years. They won't implement it (yet anyway), so we're stuck with this versioning for the time being. Yes, I searched the doc and updated the versioning for the
It will take longer than doing it this way. I'll fix that up on the other issue that I opened. Hopefully, I'll reach that in the RC time frame. |
ORF! My power is going MAD here right now. We're getting slammed by a giant thunderstorm ⚡, and I'm losing power and Internet intermittently. I'll try to wrap this up between blackouts! 😆 |
Ok ... we're good. I'll merge now. |
Fixes #32792
Addresses #32692
Addresses #31909
Beth ... This should work ... I think 🤔🤞🍀. It should work IF the new project template exactly matches what we have in the article in terms of namespace suffixes, file locations and file names, code logic, etc. I still haven't created an app from the template (YET) just because I'm working full speed at the moment 🏃♂️🏃♂️🏃♂️ just to get everything covered in time for release tomorrow. I will create a local test app to compare; but if you can tell me about any deltas that exist between the article/sample app and the template, I hope I can work up the changes for this PR and put off creating a local project at the moment.
Here's what this PR is doing to the current coverage ...
WRT the command, I included the interactivity and interactivity location options, but you might prefer that I strike them because they're probably the default ...
If you confirm that they are the default, I'll change the text a bit and remove them from that command. I'll tell the reader the defaults in the text next to the command.
I'll retain the option for naming the folder/namespace (
-o|--output MauiBlazorWeb
).Internal previews