Skip to content

Added ASP0027 documentation #35061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 26, 2025
Merged

Added ASP0027 documentation #35061

merged 3 commits into from
Mar 26, 2025

Conversation

benhopkinstech
Copy link
Contributor

@benhopkinstech benhopkinstech commented Mar 26, 2025 •
edited by github-actions bot
Loading

Added documentation for ASP0027

Fixes #35037

Internal previews

📄 File 🔗 Preview link
aspnetcore/diagnostics/asp0027.md aspnetcore/diagnostics/asp0027
aspnetcore/toc.yml aspnetcore/toc

@benhopkinstech
Copy link
Contributor Author

@martincostello not sure if you want to take a look over this, you might have some suggestions?

martincostello
martincostello reviewed Mar 26, 2025
View reviewed changes
Copy link
Member

@martincostello martincostello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@benhopkinstech benhopkinstech changed the title Added ASP0027 document Added ASP0027 documentation Mar 26, 2025
guardrex
guardrex reviewed Mar 26, 2025
View reviewed changes
@guardrex guardrex requested a review from Rick-Anderson March 26, 2025 21:53
@Rick-Anderson Rick-Anderson merged commit c1b3233 into dotnet:main Mar 26, 2025
3 checks passed
@benhopkinstech benhopkinstech deleted the 35037 branch March 26, 2025 23:13
@Rick-Anderson
Copy link
Contributor

@benhopkinstech thanks!
Check out is:issue is:open label:"code help wanted" " and is:open is:issue label:"Good first issue" if you're interested it writing some code. We'll take care of the writing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martincostello martincostello martincostello left review comments

@guardrex guardrex guardrex left review comments

@Rick-Anderson Rick-Anderson Rick-Anderson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create ASP0027 Unnecessary public Program class declaration
4 participants
@benhopkinstech @Rick-Anderson @martincostello @guardrex