Added warning when using Redis to store Data Protection keys #36219
+7
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a warning about using Redis cache to store Data Protection keys, since Redis doesn't persist data across service restarts by default. Provided links for configuration guidance.
wadepickett
approved these changes
Nov 7, 2025
Contributor
wadepickett
left a comment
wadepickett
left a comment
There was a problem hiding this comment.
Great work @wcabus, thanks! Sorry this sat in the queue for so long before it was reviewed.
The warning is clear, technically accurate, free of language errors, and correctly placed, looks good.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a critical warning to the Redis key storage provider documentation, alerting developers that Redis doesn't persist data by default when restarting, which can cause Data Protection to issue new keys and invalidate previously protected data.
Key Changes:
- Added a WARNING callout explaining Redis default persistence behavior and its impact on data protection keys
- Provided guidance on configuring Redis persistence with links to Redis documentation
- Included specific instructions for Azure Managed Redis and Azure Cache for Redis persistence configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a warning about using Redis cache to store Data Protection keys, since Redis doesn't persist data across service restarts by default. Provided links for configuration guidance.
Fixes #36305
Internal previews