-
Notifications
You must be signed in to change notification settings - Fork 25.1k
Update call-javascript-from-dotnet.md #36289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Changed the name of the handleTickerChanged1 function to displayTickerAlert1. Because in the code examples this function is called displayTickerAlert1.
|
Thanks @sharpist! ... I'm OOF at the moment, but I'll review this by EOD. |
|
I'm BACK. I had a lot going on yesterday, so I couldn't reach this last night. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sharpist! 🚀 ... I found a few more spots where the code change that was made in the Blazor samples repo didn't make its way into the article. I also modified the wording a bit. I'll wait on merging this until you've had a chance to look it over and provide additional feedback.
|
@guardrex Hi! Thank you! |
|
Are there more? I already fixed the other instances for this problem of the JS FN name. ... but Yes! if you want to make more edits here. Please go ahead. I'll wait until I hear back that you're ready for me to look at the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sharpist! 🚀 ... I think we're good to go here. I'll merge this right after it builds, and it should go live within a day or two.
|
@guardrex, okay and thank you too. 👍 |
[EDIT by guardrex to add the issue]
Fixes #36290
Changed the name of the handleTickerChanged1 function to displayTickerAlert1. Because in the code examples this function is called displayTickerAlert1.
Internal previews