Skip to content

Conversation

@sharpist
Copy link
Contributor

@sharpist sharpist commented Nov 1, 2025

[EDIT by guardrex to add the issue]

Fixes #36290

Changed the name of the handleTickerChanged1 function to displayTickerAlert1. Because in the code examples this function is called displayTickerAlert1.


Internal previews

📄 File 🔗 Preview link
aspnetcore/blazor/javascript-interoperability/call-javascript-from-dotnet.md aspnetcore/blazor/javascript-interoperability/call-javascript-from-dotnet

Changed the name of the handleTickerChanged1 function to displayTickerAlert1. Because in the code examples this function is called displayTickerAlert1.
@sharpist sharpist requested a review from guardrex as a code owner November 1, 2025 16:24
@guardrex guardrex self-assigned this Nov 1, 2025
@guardrex
Copy link
Collaborator

guardrex commented Nov 1, 2025

Thanks @sharpist! ... I'm OOF at the moment, but I'll review this by EOD.

@guardrex
Copy link
Collaborator

guardrex commented Nov 2, 2025

I'm BACK. I had a lot going on yesterday, so I couldn't reach this last night.

Copy link
Collaborator

@guardrex guardrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sharpist! 🚀 ... I found a few more spots where the code change that was made in the Blazor samples repo didn't make its way into the article. I also modified the wording a bit. I'll wait on merging this until you've had a chance to look it over and provide additional feedback.

@sharpist
Copy link
Contributor Author

sharpist commented Nov 2, 2025

@guardrex Hi! Thank you!
I'll continue editing this article. You can then choose which corrections you want.

@guardrex
Copy link
Collaborator

guardrex commented Nov 2, 2025

Are there more? I already fixed the other instances for this problem of the JS FN name.

... but Yes! if you want to make more edits here. Please go ahead. I'll wait until I hear back that you're ready for me to look at the changes.

Copy link
Collaborator

@guardrex guardrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sharpist! 🚀 ... I think we're good to go here. I'll merge this right after it builds, and it should go live within a day or two.

@guardrex guardrex merged commit 4fe10ae into dotnet:main Nov 3, 2025
4 checks passed
@sharpist
Copy link
Contributor Author

sharpist commented Nov 3, 2025

@guardrex, okay and thank you too. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix JS function name (and other small updates)

2 participants