Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PJ files from non-sample projects #5502

Merged
merged 1 commit into from
Feb 20, 2018

Conversation

guardrex
Copy link
Collaborator

Fixes #5496

What this does

This PR removes the project.json files from these projects:

  • common\samples\WebApplication1
  • migration\http-modules\sample\Asp.Net.Core
  • mvc\controllers\routing\sample\main
  • mvc\controllers\routing\sample\AreasRouting
  • mvc\controllers\application-model\sample\src\AppModelSample

These projects aren't samples linked from their topics. They only provide code snippet content.


What this doesn't do

This PR doesn't remove the project.json file from these project.json/.xproj-era projects:

  • fundamentals\servers\aspnet-core-module\sample
  • fundamentals\dependency-injection\sample\DependencyInjectionSample
  • fundamentals\error-handling\sample
  • fundamentals\app-state\sample\src\WebAppSession
  • data\entity-framework-6\sample\MVCCore
  • fundamentals\middleware\index\sample\Middleware
  • fundamentals\middleware\index\sample\Culture
  • fundamentals\middleware\index\sample\Chain
  • fundamentals\owin\sample\src\OwinSample
  • fundamentals\owin\sample\src\NowinWebSockets
  • fundamentals\owin\sample\src\NowinSample
  • migration\configuration\samples\WebApp1\src\WebApp1
  • migration\webapi\sample\ProductsCore
  • mvc\controllers\dependency-injection\sample\src\ControllerDI
  • mvc\models\file-uploads\sample\FileUploadSample
  • mvc\views\dependency-injection\sample\src\ViewInjectSample
  • performance\caching\memory\sample\WebCache
  • performance\caching\response\sample
  • mobile\native-mobile-backend\sample\ToDoApi\src\ToDoApi
  • mvc\views\working-with-forms\sample\final

All of those projects are linked into their topics as samples. They should be updated as part of the effort on Sample Update Tracking Issue #5495. At the conclusion of that work and following this PR, our IDEs (e.g., VSC) should stop flagging us to upgrade projects when we open the repo locally for work.

@scottaddie scottaddie merged commit 239aa0b into master Feb 20, 2018
@scottaddie scottaddie deleted the guardrex/drop-unused-samp branch February 20, 2018 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants