Razor Pages Filters #5835
Razor Pages Filters #5835
Conversation
|
|
||
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="Microsoft.AspNetCore.App" Version="2.1.0-preview2-30457" /> |
There was a problem hiding this comment.
Should we just point this to 2.1.0-preview2-final (when it's available, which is likely soon)?
aspnetcore/mvc/razor-pages/filter.md
Outdated
|
|
||
| [!code-csharp[Main](filter/sample/PageFilter/StartupSync.cs?name=snippet2&highlight=11)] | ||
|
|
||
| ## Implement Razor Page filters by overriding page handlers |
There was a problem hiding this comment.
overriding filter methods (not handlers)
|
Yet another thing, that's missing is specifying filters on |
|
@pranavkm can you send me the code for a filter attribute? |
|
You could use the same |
|
@fmaeseele please review. |
|
@pranavkm Can you take another look. It should be ready. |
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <Content Update="Pages\About.cshtml"> |
| _value = value; | ||
| } | ||
|
|
||
| public override async Task OnResultExecutionAsync( |
There was a problem hiding this comment.
Could you change this to public override void OnResultExecuting(ResultExecutingContext context)`? Would be simpler than the async overload.
| @@ -0,0 +1,8 @@ | |||
| @page | |||
There was a problem hiding this comment.
Is this intentional? The folder name \ file name seem a bit suspect.
There was a problem hiding this comment.
I deleted about2. I don't need it to show:
services.AddMvc()
.AddRazorPagesOptions(options =>
{
options.Conventions.AddFolderApplicationModelConvention(
"/subFolder",
model => model.Filters.Add(new SampleAsyncPageFilter(_logger)));
});
|
|
||
| public static IWebHostBuilder CreateWebHostBuilder(string[] args) => | ||
| WebHost.CreateDefaultBuilder(args) | ||
| // .UseStartup<StartupSync>(); |
There was a problem hiding this comment.
I formatted the commented out code but I need all 3 startup class references to test the 3 startup classes - depending on what I want to show.
| @@ -0,0 +1,53 @@ | |||
| using Microsoft.AspNetCore.Builder; | |||
| { | ||
| options.Conventions.AddFolderApplicationModelConvention( | ||
| "/subFolder", | ||
| model => model.Filters.Add(new SampleAsyncPageFilter(_logger))); |
There was a problem hiding this comment.
Is there value in showing a sync and async filter being added globally? I'd pick one as long as we show a sample of a sync filter and an async filter being used.
There was a problem hiding this comment.
That sample is to show AddFolderApplicationModelConvention
In the rendered document, this async filter is shown in the previous snippet.
| @@ -0,0 +1,37 @@ | |||
| /* Please see documentation at https://docs.microsoft.com/aspnet/core/client-side/bundling-and-minification | |||
There was a problem hiding this comment.
Out of curiosity, do we always include all the css \ scripts with these samples?
There was a problem hiding this comment.
I lost that battle long ago. I used to exclude them with .gitignore and require you to manually override the ignore file. Now I ask folks to manually exclude them which is usually forgotten.
aspnetcore/toc.md
Outdated
| @@ -246,7 +249,6 @@ | |||
| ### [Build Docker images](/dotnet/articles/core/docker/building-net-docker-images) | |||
| ### [Visual Studio Tools for Docker](xref:host-and-deploy/docker/visual-studio-tools-for-docker) | |||
| ### [Publish to a Docker image](https://azure.microsoft.com/documentation/articles/vs-azure-tools-docker-hosting-web-apps-in-docker/) | |||
| ## [Proxy and load balancer configuration](xref:host-and-deploy/proxy-load-balancer) | |||
Fixes #5754
Review URL
Clean up of Filters in ASP.NET Core