Required #6294
Merged
Required #6294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guardrex
approved these changes
May 9, 2018
| @@ -5,7 +5,7 @@ description: Learn how Razor Pages in ASP.NET Core makes coding page-focused sce | |||
| manager: wpickett | |||
| monikerRange: '>= aspnetcore-2.0' | |||
| ms.author: riande | |||
| ms.date: 09/12/2017 | |||
| ms.date: 5/12/2018 | |||
aspnetcore/mvc/razor-pages/index.md
Outdated
| @@ -205,6 +205,13 @@ The `OnPostDeleteAsync` method: | |||
| * Calls `RedirectToPage` to redirect to the root Index page (`/Index`). | |||
|
|
|||
| ::: moniker range=">= aspnetcore-2.1" | |||
|
|
|||
| ## Mark Page properties as required | |||
There was a problem hiding this comment.
"Page" in this context ... not a proper noun I think (?)
Since "as" precedes "required," it seems to be calling out the actual attribute name. Therefore, proper noun (?) ... either Required or [Required] (?)
aspnetcore/mvc/razor-pages/index.md
Outdated
| `SetCompatibilityVersion` effectively sets the Razor Pages option `AllowMappingHeadRequestsToGetHandler` to `true`. The behavior is opt-in until the release of ASP.NET Core 3.0 Preview 1 or later. Each major version of ASP.NET Core adopts all of the patch release behaviors of the previous version. | ||
| `SetCompatibilityVersion` effectively sets the Razor Pages option `AllowMappingHeadRequestsToGetHandler` to `true`. | ||
|
|
||
| Rather than opting in to all 2.1 behaviors with `SetCompatibilityVersion`, you can explicitly opt-in to specific behaviors. The following code opts-in to the mapping HEAD requests to the GET handler. |
There was a problem hiding this comment.
I see various remarks on phrasing "opting in to" vs. "opting into" ... I kind'a like the latter.
"opt-in" (verb) 👉 "opt in" but might add the "to" 👉 "opt into"
Same with the last "opts-in" (verb) ... "opts in" if not "opts into" as well.
to the mapping HEAD requests to the GET handler.
Drop the "the" in that phrase?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5834
Review URL