partial warning #6435
Merged
partial warning #6435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guardrex
approved these changes
May 16, 2018
aspnetcore/testing/troubleshoot.md
Outdated
| ::: moniker range=">= aspnetcore-2.1" | ||
|
|
||
| ### Use of IHtmlHelper.Partial may result in application deadlocks. |
There was a problem hiding this comment.
No period on section header
aspnetcore/testing/troubleshoot.md
Outdated
| In ASP.NET Core 2.1 and later, calling `Html.Partial` will result in an analyzer warning due to the potential for deadlocks. The warning message is: | ||
|
|
||
| *Use of IHtmlHelper.Partial may result in application deadlocks. Consider using `<partial>` Tag Helper or `IHtmlHelper.PartialAsync`. |
There was a problem hiding this comment.
Italics are started (*) but not ended. Missing a closing asterisk?
aspnetcore/testing/troubleshoot.md
Outdated
| ### Use of IHtmlHelper.Partial may result in application deadlocks. | ||
|
|
||
| In ASP.NET Core 2.1 and later, calling `Html.Partial` will result in an analyzer warning due to the potential for deadlocks. The warning message is: |
There was a problem hiding this comment.
Remove future tense: "will result in" 👉 "results in"
|
@Rick-Anderson Should this be moved to the following doc instead? https://docs.microsoft.com/aspnet/core/mvc/views/partial |
|
Good idea. I'll do that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5938
