HTTP2 scenario coverage #8519

guardrex · 2018-09-13T18:52:31Z

Internal Review Topic (Servers landing page)
Internal Review Topic (Kestrel)
Internal Review Topic (HTTP.sys)
Internal Review Topic (IIS)
Internal Review Topic (Linux Nginx)
Internal Review Topic (Linux Apache)

No doubt in need of corrections and additions. I still had to guess on a few items, but it should be easy to sort these spots out on review.

Opened Add API links to HTTP/2 content #8518 to update the API references to links.

Updates Updates Updates JSON fixes Updates Updates

Tratcher · 2018-09-16T18:33:01Z

aspnetcore/fundamentals/servers/httpsys.md

+* [Application-Layer Protocol Negotiation (ALPN)](https://tools.ietf.org/html/rfc7301#section-3) connection
+* TLS 1.2 or later connection
+
+If an HTTP/2 connection is established, [HttpRequest.Protocol](xref:Microsoft.AspNetCore.Http.HttpRequest.Protocol*) reports `HTTP/2`.


This is new in 2.2. prior versions reported http/1.1 even for http/2 requests.

Tratcher · 2018-09-16T18:42:42Z

aspnetcore/fundamentals/servers/kestrel.md

+```csharp
+.ConfigureKestrel((context, options) =>
+{
+    options.Limits.MaxStreamsPerConnection = 100;


Limits.Http2.* for all of these new ones.

Tratcher · 2018-09-16T18:57:40Z

aspnetcore/fundamentals/servers/kestrel.md

+
+The `Protocols` property establishes the HTTP protocols (`HttpProtocols`) enabled on a connection endpoint or for the server. Assign a value to the `Protocols` property from the `HttpProtocols` enum.
+
+| `HttpProtocols` enum value | Connection protocol permitted |


Tls restrictions:
Http1 - can be used with or without tls
Http2 - primarily used with tls. May be used without tls only if the client supports a Prior Knowledge mode.
Http1AndHttp2 - requires tls & alpn to negotiate http2, otherwise defaults to http1.

Let me know if you have a link for "Prior Knowledge mode."

https://tools.ietf.org/html/rfc7540#section-3.4

Tratcher · 2018-09-16T19:03:46Z

aspnetcore/host-and-deploy/linux-apache.md

+
+## HTTP/2 support
+
+[HTTP/2](https://httpwg.org/specs/rfc7540.html) is available for ASP.NET Core apps running directly on the [Kestrel server](xref:fundamentals/servers/kestrel#http2-support) if the following base requirements are met:


This is a bit odd in the Apache doc. Does Apache support forwarding http/2?

Perhaps not ... this was one of my points of confusion from your outline. Under "Kestrel: OS," you have ...

Linux W/OpenSSL 1.0.2 (e.g. Ubuntu 16.04)

... which sounds like ur saying that Kestrel can run directly on Linux. I have no personal knowledge beyond what @shirhatti has documented.

Linux, yes, but these docs are specifically about Apache and Nginx. They are reverse proxies like ANCM. Unless we have http/2 notes specific to them then there's no need to update these.

Tratcher · 2018-09-16T19:05:27Z

aspnetcore/host-and-deploy/linux-nginx.md

+
+## HTTP/2 support
+
+[HTTP/2](https://httpwg.org/specs/rfc7540.html) is available for ASP.NET Core apps running directly on the [Kestrel server](xref:fundamentals/servers/kestrel#http2-support) if the following base requirements are met:


Same as apache

Tratcher · 2018-09-16T22:23:49Z

aspnetcore/fundamentals/servers/index.md

+    * Windows Server 2012 R2/Windows 8.1 or later
+    * Linux with OpenSSL 1.0.2 or later (for example, Ubuntu 16.04 or later)
+    * HTTP/2 will be supported on macOS in a future release.
+  * Target framework: ASP.NET Core 2.2 or later


.NET Core 2.2, not ASP.NET Core 2.2. .NET 4.x doesn't support ALPN or HTTP/2.

Should it say "Shared framework: ..." since we don't want to confuse TFMs with this remark?

TFM is more applicable. In-proc and ALPN both have dependencies on .NET Core 2.2 and don't support .NET 4.x.

Tratcher · 2018-09-16T22:24:29Z

aspnetcore/fundamentals/servers/index.md

+  * Target framework: Not applicable to HTTP.sys deployments.
+* [IIS (in-process)](xref:host-and-deploy/iis/index#http2-support)
+  * Windows Server 2016/Windows 10 or later; IIS 10 or later
+  * Target framework: ASP.NET Core 2.2 or later


.NET Core 2.2, no .NET 4.x support for in-proc.

Tratcher · 2018-09-16T22:26:55Z

aspnetcore/fundamentals/servers/kestrel.md

+* Operating system&dagger;
+  * Windows Server 2012 R2/Windows 8.1 or later
+  * Linux with OpenSSL 1.0.2 or later (for example, Ubuntu 16.04 or later)
+* Target framework: ASP.NET Core 2.2 or later


.NET Core 2.2

Tratcher · 2018-09-16T22:30:55Z

aspnetcore/fundamentals/servers/kestrel.md

+| `HttpProtocols` enum value | Connection protocol permitted |
+| -------------------------- | ----------------------------- |
+| `Http1`                    | HTTP/1.1 only. Can be used with or without TLS. |
+| `Http2`                    | HTTP/2 only. Primarily used with TLS 1.2 or later. May be used without TLS 1.2 or later only if the client supports a [Prior Knowledge mode](https://tools.ietf.org/html/rfc7540#section-3.4). |


~~1.2 or later~~ is distracting here. It's not about the version, it's a bout TLS vs clear text.

Tratcher · 2018-09-16T22:31:53Z

aspnetcore/fundamentals/servers/kestrel.md

+| -------------------------- | ----------------------------- |
+| `Http1`                    | HTTP/1.1 only. Can be used with or without TLS. |
+| `Http2`                    | HTTP/2 only. Primarily used with TLS 1.2 or later. May be used without TLS 1.2 or later only if the client supports a [Prior Knowledge mode](https://tools.ietf.org/html/rfc7540#section-3.4). |
+| `Http1AndHttp2`            | HTTP/1.1 and HTTP/2. Requires a TLS 1.2 or later and [Application-Layer Protocol Negotiation (ALPN)](https://tools.ietf.org/html/rfc7301#section-3) connection to negotiate HTTP/2; otherwise, the connection defaults to HTTP/1.1. |


Same about the version here.

Tratcher · 2018-09-16T22:34:00Z

aspnetcore/host-and-deploy/iis/index.md

+
+* In-process
+  * Windows Server 2016/Windows 10 or later; IIS 10 or later
+  * Target framework: ASP.NET Core 2.2 or later


.NET Core 2.2

Tratcher · 2018-09-16T22:35:17Z

aspnetcore/host-and-deploy/iis/index.md

+
+* Windows Server 2016/Windows 10 or later; IIS 10 or later
+* Edge connections use HTTP/2, but the reverse proxy connection to the [Kestrel server](xref:fundamentals/servers/kestrel) uses HTTP/1.1.
+* Target framework: Not applicable to out-of-process deployments, since the HTTP/2 connection is handled entirely by IIS.


TLS 1.2 or later connection

Tratcher · 2018-09-16T22:40:32Z

aspnetcore/host-and-deploy/iis/index.md

+
+::: moniker-end
+
+If an HTTP/2 connection is established, [HttpRequest.Protocol](xref:Microsoft.AspNetCore.Http.HttpRequest.Protocol*) reports `HTTP/2`.


HttpRequest.Protocol is only set to Http/2 for in proc, not out of proc.

scottaddie · 2018-09-17T14:48:58Z

aspnetcore/fundamentals/servers/kestrel.md

+`Http2.MaxStreamsPerConnection` limits the number of concurrent request streams per HTTP/2 connection. Excess streams are refused.
+
+```csharp
+.ConfigureKestrel((context, options) =>


Indicate where this code belongs.

nah ..... changed my mind lol

Let me see if I can deal with all 12 of these instances right now. The sample issue tho still remains, and so does the issue to address Kestrel topic sections/section headers.

scottaddie · 2018-09-17T14:50:04Z

aspnetcore/fundamentals/servers/kestrel.md

+The following example permits HTTP/1.1 and HTTP/2 connections on port 8000. Connections are secured by TLS with a supplied certificate:
+
+```csharp
+options.Listen(IPAddress.Any, 8000, listenOptions =>


Indicate where this code belongs.

guardrex · 2018-09-17T15:44:47Z

@scottaddie kk --- that might† get every one, including UseKestrel, in context.

†This topic has become a 🐻 to work on.

IIRC there will be overlap between 1.x and 3.0, as I think 1.x probably depreciates after 3.0 RTM.

I pray to the 🙏 server gods 🙏 for file versioning by then.

guardrex · 2018-09-17T16:04:17Z

ty @scottaddie

@Tratcher U ok with the latest updates?

Tratcher · 2018-09-17T19:14:01Z

guardrex force-pushed the guardrex/http2 branch from 5d68a2a to a31b317 Compare September 13, 2018 18:58

guardrex changed the title ~~HTTP2 scenario coverage~~ [WIP] HTTP2 scenario coverage Sep 13, 2018

guardrex added the WIP label Sep 13, 2018

guardrex force-pushed the guardrex/http2 branch from dc140e6 to 1880ef2 Compare September 16, 2018 15:41

HTTP2 scenario coverage

d49d4e6

Updates Updates Updates JSON fixes Updates Updates

guardrex force-pushed the guardrex/http2 branch from c476775 to d49d4e6 Compare September 16, 2018 15:52

guardrex changed the title ~~[WIP] HTTP2 scenario coverage~~ HTTP2 scenario coverage Sep 16, 2018

guardrex removed the WIP label Sep 16, 2018

guardrex requested a review from Tratcher September 16, 2018 15:54

Tratcher reviewed Sep 16, 2018

View reviewed changes

guardrex added 3 commits September 16, 2018 14:20

React to feedback

a3ad5ef

React to feedback

156473a

Fix Linux date

950cbc6

Tratcher approved these changes Sep 16, 2018

View reviewed changes

Tratcher reviewed Sep 16, 2018

View reviewed changes

guardrex added 2 commits September 16, 2018 17:59

React to feedback

443ce6a

"Target framework"

8fd60db

guardrex requested a review from scottaddie September 17, 2018 00:27

scottaddie reviewed Sep 17, 2018

View reviewed changes

React to feedback

a1033b9

scottaddie approved these changes Sep 17, 2018

View reviewed changes

guardrex merged commit 097d3b2 into master Sep 17, 2018

guardrex deleted the guardrex/http2 branch September 17, 2018 19:14

guardrex mentioned this pull request Sep 21, 2018

Add API links and perform 2.2 RTM updates #8518

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HTTP2 scenario coverage #8519

HTTP2 scenario coverage #8519

guardrex commented Sep 13, 2018 •

edited

Loading

Tratcher Sep 16, 2018

Tratcher Sep 16, 2018

Tratcher Sep 16, 2018

guardrex Sep 16, 2018

Tratcher Sep 16, 2018

Tratcher Sep 16, 2018

guardrex Sep 16, 2018

Tratcher Sep 16, 2018

Tratcher Sep 16, 2018

Tratcher Sep 16, 2018

guardrex Sep 16, 2018

Tratcher Sep 16, 2018 •

edited

Loading

Tratcher Sep 16, 2018

Tratcher Sep 16, 2018

Tratcher Sep 16, 2018

Tratcher Sep 16, 2018

Tratcher Sep 16, 2018

Tratcher Sep 16, 2018

Tratcher Sep 16, 2018

scottaddie Sep 17, 2018

guardrex Sep 17, 2018

scottaddie Sep 17, 2018

guardrex commented Sep 17, 2018

guardrex commented Sep 17, 2018

Tratcher commented Sep 17, 2018


		The `Protocols` property establishes the HTTP protocols (`HttpProtocols`) enabled on a connection endpoint or for the server. Assign a value to the `Protocols` property from the `HttpProtocols` enum.

		\| `HttpProtocols` enum value \| Connection protocol permitted \|


		## HTTP/2 support

		[HTTP/2](https://httpwg.org/specs/rfc7540.html) is available for ASP.NET Core apps running directly on the [Kestrel server](xref:fundamentals/servers/kestrel#http2-support) if the following base requirements are met:


		::: moniker-end

		If an HTTP/2 connection is established, [HttpRequest.Protocol](xref:Microsoft.AspNetCore.Http.HttpRequest.Protocol*) reports `HTTP/2`.

HTTP2 scenario coverage #8519

HTTP2 scenario coverage #8519

Conversation

guardrex commented Sep 13, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Tratcher Sep 16, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

guardrex commented Sep 17, 2018

guardrex commented Sep 17, 2018

Tratcher commented Sep 17, 2018

guardrex commented Sep 13, 2018 •

edited

Loading

Tratcher Sep 16, 2018 •

edited

Loading