Add Show Comments button #931
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@javiercn @Rick-Anderson @rachelappel @Erikre Please review |
|
|
|
I propose you do one of these two things:
Right you can repeatedly press the show comments, and there is no feedback to indicate nothing happens after the first time you press it |
|
@shirhatti I opted for # 2. |
|
#2 is the right choice. |
| /* * * DON'T EDIT BELOW THIS LINE * * */ | ||
| var dsq = document.createElement('script'); dsq.type = 'text/javascript'; dsq.async = true; | ||
| dsq.src = 'https://' + disqus_shortname + '.disqus.com/embed.js'; | ||
| (document.getElementsByTagName('head')[0] || document.getElementsByTagName('body')[0]).appendChild(dsq); |
There was a problem hiding this comment.
You've used a JQuery style DOM selector in line 1 and a vanilla js DOM selector in line 13. Maybe try and be consistent?
There was a problem hiding this comment.
This part of the code is the recommended code snippet from the disqus docs, so I'm leaving it untouched.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@shirhatti Please review