Add docs for api conventions and analyzers #9453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottaddie
requested changes
Nov 5, 2018
| title: Using web API analyzers | ||
| author: pranavkm | ||
| description: Learn about analyzers in Microsoft.AspNetCore.Mvc.Api.Analyzers | ||
| ms.author: pranavkm |
There was a problem hiding this comment.
Add the following metadata above this line, so that the doc is only available for ASP.NET Core 2.2+:
monikerRange: '>= aspnetcore-2.2'
aspnetcore/web-api/advanced/index.md
Outdated
| @@ -11,3 +11,5 @@ uid: web-api/advanced/index | |||
|
|
|||
| * [Custom formatters](xref:web-api/advanced/custom-formatters) | |||
| * [Format response data](xref:web-api/advanced/formatting) | |||
| * [Web api Conventions](xref:web-api/api-conventions) | |||
There was a problem hiding this comment.
@tdykstra Shouldn't this file be deleted?
There was a problem hiding this comment.
Yes, deleted and redirected, I missed it earlier.
There was a problem hiding this comment.
Thanks, Tom. I'll take care of that right now.
There was a problem hiding this comment.
@pranavkm I deleted this file in another PR. You may want to rebase your branch on top of master.
|
🆙 📅 |
pranavkm
force-pushed
the
prkrishn/open-api
branch
from
3fba852 to
c98c41a
Compare
|
@scottaddie 🆙 📅 |
|
@scottaddie is this ready to merge? What's needed? |
|
@Rick-Anderson I have one last build warning to resolve, and then this is ready. |
* Edit pass on 2.2 API docs * Resolve build warning
|
Thank you for the help with this, @pranavkm! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8332
Internal Review Pages