-
Notifications
You must be signed in to change notification settings - Fork 25.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update options for 2.2 #9456
Update options for 2.2 #9456
Conversation
WIP (switching browsers) not ready for review
@guardrex can you review? |
Sure thing @HaoK ... to save time, should I just edit any grammar/style things directly, or would you prefer comments? |
Nah just edit away, I noticed my wordsmithing skills were...not great compared to the rest of the doc, hopefully you can help fix that :) |
We were just chatting about this on another issue: We try to doc the current scenario for the current version and not make reference to prior versions, plans for the future, and reasons for the changes. We just let the versioning of the content take care of it. We're up to ~400 markdown files now, and this approach helps. Are u ok if I revise without that language? ... then you can tell me what a goober I am on review? ... that's our normal pattern, isn't it? 😀 lol |
Sounds good @guardrex |
@guardrex can we get this merged? |
If the language that calls out explicit versions is ok, yes ... merge now. If I should go thru and try to eliminate language that refers to specific versions, then I can do that tomorrow (Fri, 11/9) ... hold for a day. |
Tomorrow is fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HaoK ... Do you want to take a look at the UE update on the last commit?
Reads much better thanks for polishing it up @guardrex ! Looks good to me |
Fixes #9443
Fixes #9232