Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update options for 2.2 #9456

Merged
merged 4 commits into from
Nov 9, 2018
Merged

Update options for 2.2 #9456

merged 4 commits into from
Nov 9, 2018

Conversation

HaoK
Copy link
Member

@HaoK HaoK commented Nov 5, 2018

Fixes #9443
Fixes #9232

HaoK added 2 commits November 5, 2018 13:04
WIP (switching browsers) not ready for review
@HaoK HaoK changed the title [WIP] Update options for 2.2 Update options for 2.2 Nov 5, 2018
@HaoK
Copy link
Member Author

HaoK commented Nov 5, 2018

@guardrex can you review?

@guardrex
Copy link
Collaborator

guardrex commented Nov 5, 2018

Sure thing @HaoK ... to save time, should I just edit any grammar/style things directly, or would you prefer comments?

@guardrex guardrex self-requested a review November 5, 2018 23:07
@HaoK
Copy link
Member Author

HaoK commented Nov 5, 2018

Nah just edit away, I noticed my wordsmithing skills were...not great compared to the rest of the doc, hopefully you can help fix that :)

@guardrex
Copy link
Collaborator

guardrex commented Nov 5, 2018

@HaoK

was introduced in 2.1 to

has been a source of friction and prior to 2.1

Starting in 2.1

is something we are still thinking about for a future release

We were just chatting about this on another issue: We try to doc the current scenario for the current version and not make reference to prior versions, plans for the future, and reasons for the changes. We just let the versioning of the content take care of it. We're up to ~400 markdown files now, and this approach helps.

Are u ok if I revise without that language? ... then you can tell me what a goober I am on review? ... that's our normal pattern, isn't it? 😀 lol

@HaoK
Copy link
Member Author

HaoK commented Nov 6, 2018

Sounds good @guardrex

@Rick-Anderson
Copy link
Contributor

@guardrex can we get this merged?

@guardrex
Copy link
Collaborator

guardrex commented Nov 8, 2018

If the language that calls out explicit versions is ok, yes ... merge now.

If I should go thru and try to eliminate language that refers to specific versions, then I can do that tomorrow (Fri, 11/9) ... hold for a day.

@guardrex guardrex self-assigned this Nov 8, 2018
@Rick-Anderson
Copy link
Contributor

Tomorrow is fine.

Copy link
Collaborator

@guardrex guardrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HaoK ... Do you want to take a look at the UE update on the last commit?

@guardrex guardrex removed their assignment Nov 9, 2018
@HaoK
Copy link
Member Author

HaoK commented Nov 9, 2018

Reads much better thanks for polishing it up @guardrex ! Looks good to me

@guardrex guardrex merged commit 3addeff into master Nov 9, 2018
@delete-merged-branch delete-merged-branch bot deleted the HaoK-optionsbuilder-1 branch November 9, 2018 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document new Options Validation feature in 2.2 Doc 2.1 API ConfigureOptions
3 participants