Improve HardwareCounters validation, see #1856

dotnet · Mar 8, 2023 · 6162e9d · 6162e9d
1 parent 975a0e0
commit 6162e9d
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/src/BenchmarkDotNet.Diagnostics.Windows/HardwareCounters.cs b/src/BenchmarkDotNet.Diagnostics.Windows/HardwareCounters.cs
@@ -50,8 +50,14 @@ public static IEnumerable<ValidationError> Validate(ValidationParameters validat
 
  foreach (var hardwareCounter in validationParameters.Config.GetHardwareCounters())
  {
- if (!EtwTranslations.TryGetValue(hardwareCounter, out var counterName))
- yield return new ValidationError(true, $"Counter {hardwareCounter} not recognized. Please make sure that you are using counter available on your machine. You can get the list of available counters by running `tracelog.exe -profilesources Help`");
+ if (!EtwTranslations.TryGetValue(hardwareCounter, out string counterName))
+ {
+ yield return new ValidationError(true,
+ $"Counter {hardwareCounter} not recognized. " +
+ $"Please make sure that you are using counter available on your machine. " +
+ $"You can get the list of available counters by running `tracelog.exe -profilesources Help`");
+ continue;
+ }
 
  if (!availableCpuCounters.ContainsKey(counterName))
  yield return new ValidationError(true, $"The counter {counterName} is not available. Please make sure you are Windows 8+ without Hyper-V");