Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a "benchmark" cmd to dotnet #213

Closed
mattwarren opened this issue Jun 16, 2016 · 8 comments
Closed

Add a "benchmark" cmd to dotnet #213

mattwarren opened this issue Jun 16, 2016 · 8 comments

Comments

@mattwarren
Copy link
Contributor

So it seems like you can add extra commands to the dotnet tooling, how cool would it be to be able to do dotnet benchmark?

This could then interact with the BenchmarkSwitcher so you can do --class=Benchmarks, --diagnosers=Memory, etc

From my understanding we would have to propose it as a CLI issue, but if we were serious about it, I think someone should do a proof-of-concept first.

Anyone agree? Anyone want to take it on?

@adamsitnik
Copy link
Member

Good idea, but as for me I don't have time now.

@AndreyAkinshin
Copy link
Member

An interesting post about the subj: https://surfingthecode.com/fun-with-global-tools-in-.net-core-2.1-preview/

@AndreyAkinshin
Copy link
Member

The official documentation: https://docs.microsoft.com/en-us/dotnet/core/tools/global-tools

@CodeTherapist
Copy link
Contributor

I would like to do this.

@AndreyAkinshin
Copy link
Member

@CodeTherapist, great!

@CodeTherapist
Copy link
Contributor

CodeTherapist commented Jan 9, 2019

@AndreyAkinshin, Done! At least a first version of it - let me know if that solves this issue.

The tool supports the following syntax:

dotnet benchmarkdotnet [YourAssemblyFileWithBenchmarks.dll] [BenchmarkDotNet Arguments]

Btw. I'm little bit confused because the build is failing.
I can't imagine how my change could break this test or did I missed something?

@adamsitnik
Copy link
Member

@CodeTherapist this particular failure is not your fault, I am going to take a look into that failure to see what is going on

adamsitnik pushed a commit that referenced this issue Jan 12, 2019
* BenchmarkDotNet as global tool

This resolves #213.

* Set TargetFramework to "netcoreapp2.1"

* Add import for common build properties.

* Docs: BenchmarkDotNet as global dotnet tool
@adamsitnik adamsitnik added this to the v0.11.4 milestone Jan 12, 2019
@adamsitnik
Copy link
Member

Implemented in #1006

adamsitnik added a commit that referenced this issue Feb 1, 2019
BenchmarkDotNet as global tool (#1006), fixes #213
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants