Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ScottPlotExporter is incorrectly calculating mean on measurements from all iteration stages #2611

Closed
FlatlinerDOA opened this issue Aug 11, 2024 · 0 comments · Fixed by #2612
Closed

ScottPlotExporter is incorrectly calculating mean on measurements from all iteration stages #2611

FlatlinerDOA opened this issue Aug 11, 2024 · 0 comments · Fixed by #2612
Assignees
@FlatlinerDOA
Milestone
v0.14.1

Comments

@FlatlinerDOA
Copy link
Contributor

The ScottPlotExporter is calculating the mean across all measurements, not just IterationStage == Result , so measurements like overhead is being included, biasing the plot.
FlatlinerDOA added a commit to FlatlinerDOA/BenchmarkDotNet that referenced this issue Aug 11, 2024
@FlatlinerDOA
Fix dotnet#2611 - Add Iteration mode and stage filtering
1d7a576
FlatlinerDOA added a commit to FlatlinerDOA/BenchmarkDotNet that referenced this issue Aug 11, 2024
@FlatlinerDOA
Fix dotnet#2611 - Also choose time scale based on results
0209d80
This was referenced Aug 11, 2024
Merged
Merged
Merged
Open
AndreyAkinshin pushed a commit that referenced this issue Aug 25, 2024
@FlatlinerDOA
Fix #2611 - Add Iteration mode and stage filtering to ScottPlotExport…
3927ce7 
…er (#2612)

* Fix #2611 - Add Iteration mode and stage filtering

* Fix #2611 - Also choose time scale based on results
@AndreyAkinshin AndreyAkinshin added this to the v0.14.1 milestone Aug 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FlatlinerDOA FlatlinerDOA

Labels
None yet
Projects
None yet
Milestone
v0.14.1
Development

Successfully merging a pull request may close this issue.

Fix #2611 - Add Iteration mode and stage filtering to ScottPlotExporter FlatlinerDOA/BenchmarkDotNet
2 participants
@FlatlinerDOA @AndreyAkinshin