Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1655 doc with options obsolete usage of with #1657

Merged
merged 2 commits into from
Feb 25, 2021
Merged

1655 doc with options obsolete usage of with #1657

merged 2 commits into from
Feb 25, 2021

Conversation

cedric-cf
Copy link
Contributor

Fix #1655

Update the documentation https://github.com/dotnet/BenchmarkDotNet/blob/master/docs/articles/configs/configoptions.md/#L1

  • Replace the method With by WithOptions
  • Remove the section about the use of Options.Set(<boolean>, <ConfigOptions>), because ConfigOptionsExtensions is internal.

@dnfadmin
Copy link

dnfadmin commented Feb 25, 2021 •
edited
Loading

CLA assistant check
All CLA requirements met.

adamsitnik
adamsitnik approved these changes Feb 25, 2021
View reviewed changes
Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @cedric-cf !

@adamsitnik adamsitnik merged commit b4e2b69 into dotnet:master Feb 25, 2021
@adamsitnik adamsitnik added this to the v0.13.0 milestone Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamsitnik adamsitnik adamsitnik approved these changes

Assignees
No one assigned
Labels
Area:Documentation enhancement
Projects
None yet
Milestone
v0.13.0
Development

Successfully merging this pull request may close these issues.

Documentation - Obsolete usage of the 'With' method in place of 'WithOptions'
3 participants
@cedric-cf @dnfadmin @adamsitnik