-
-
Notifications
You must be signed in to change notification settings - Fork 1k
fixes(configuration): Not unique exporter for exporter type #1702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes(configuration): Not unique exporter for exporter type #1702
Conversation
c2d6400 to
3ee9743
Compare
3ee9743 to
3333d84
Compare
AndreyAkinshin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that the logging approach is the best way to report a warning in this case. In most cases, BenchmarkDotNet users read only the bottom part of the log (with the summary table) and don't scroll up. Thus, this warning will be most likely lost.
On the other hand, we could define IAnalyser which reports such a warning. The IAnalyser approach has two advantages:
- It prints all the warning below the summary table (so the warnings are more visible for the users)
- The list of the warnings could be fetched programmatically (so it's possible to introduce an assertion that the benchmarks don't produce any warnings).
However, this particular case is tricky because we have to report warning on the stage of config building (not at the final stage of the BenchmarkReport analysis). I guess, we could introduce an IReadOnlyList<Conclusion> property in IConfig and use it to report issues related to malformed config in a structured way.
@adamsitnik what do you think?
3333d84 to
c144702
Compare
e6ca125 to
2c14fed
Compare
dc201a2 to
0f01984
Compare
0f01984 to
b0efdf0
Compare
b0efdf0 to
e47a3b1
Compare
|
Please @AndreyAkinshin can you review? If the proposed changes are not to your liking. Please close this PR. 😄 |
e47a3b1 to
716eabb
Compare
716eabb to
5fe771f
Compare
Assembly-level configuration attributes must have a lower priority than class to allow overriding their behavior.
…dy present in the configuration.
…y already exist in configuration
LoggerAnalyzer, allow to show a assertion on the summary when in the benchmark there is some warnings or errors.
5fe771f to
f172a3f
Compare
|
Closed since #1796 looks better. |
fixes #1700
This PR